RESOLVED FIXED 146220
[cssjit] Disable compiling scrollbar pseudoclass selectors 
https://bugs.webkit.org/show_bug.cgi?id=146220
Summary [cssjit] Disable compiling scrollbar pseudoclass selectors
Alex Christensen
Reported 2015-06-22 18:01:17 PDT
Selectors like this don't work correctly in the css jit body :not(.example_id):hover::-webkit-scrollbar-thumb:horizontal Let's just not compile them until this is fixed.
Attachments
Patch (1.57 KB, patch)
2015-06-22 18:04 PDT, Alex Christensen 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-06-22 18:03:17 PDT
This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=146221
Alex Christensen
Comment 2 2015-06-22 18:04:37 PDT
Created attachment 255382 [details] Patch
Benjamin Poulain
Comment 3 2015-06-22 18:06:59 PDT
Comment on attachment 255382 [details] Patch Ok
Alex Christensen
Comment 4 2015-06-22 18:10:16 PDT
http://trac.webkit.org/changeset/185854
Simon Fraser (smfr)
Comment 5 2015-06-22 18:19:36 PDT
Why doesn't the changelog explain why you disabled them?
Alex Christensen
Comment 6 2015-06-22 18:31:19 PDT
I figured that information would be in bugzilla. Maybe I should put more info in the ChangeLogs. This patch makes it use the correct non-compiled CSS selector interpreter with scrollbar pseudo classes instead of the css jit, which behaves incorrectly with :not and scrollbar pseudo classes. It is a slight performance hit when scrollbars are used, which is not very often.
Note You need to log in before you can comment on or make changes to this bug.