Bug 146209 - Web Inspector: Background of Computed Styles is missing
Summary: Web Inspector: Background of Computed Styles is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-22 11:28 PDT by Devin Rousso
Modified: 2015-06-24 09:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2015-06-22 11:34 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2015-06-23 19:03 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2015-06-22 11:28:11 PDT 
The background of the computed styles panel is currently set to transparent.  It should actually be white.
Comment 1 Radar WebKit Bug Importer 2015-06-22 11:28:36 PDT 
<rdar://problem/21488223>
Comment 2 Devin Rousso 2015-06-22 11:34:59 PDT 
Created attachment 255356 [details]
Patch
Comment 3 Timothy Hatcher 2015-06-22 12:44:13 PDT 
Comment on attachment 255356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255356&action=review

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:27
> +    background-color: #fff;

Should be "white".
Comment 4 Nikita Vasilyev 2015-06-22 19:36:55 PDT 
This is a regression from http://trac.webkit.org/changeset/185836 (sorry!).

Besides #fff/white, the patch looks fine to me.
Comment 5 Devin Rousso 2015-06-23 19:03:19 PDT 
Created attachment 255468 [details]
Patch
Comment 6 WebKit Commit Bot 2015-06-24 09:37:24 PDT 
Comment on attachment 255468 [details]
Patch

Clearing flags on attachment: 255468

Committed r185913: <http://trac.webkit.org/changeset/185913>
Comment 7 WebKit Commit Bot 2015-06-24 09:37:29 PDT 
All reviewed patches have been landed.  Closing bug.