Bug 146206 – [ES6] Support rest element in destructuring assignments

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[ES6] Support rest element in destructuring assignments

[Yusuke Suzuki]

Created attachment 255394 [details]
Patch

[WebKit Commit Bot]

Attachment 255394 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/parser/Nodes.h:1794:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 255394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255394&action=review

> Source/JavaScriptCore/parser/Nodes.h:1794
> +            m_targetPatterns.append(Entry{ bindingType, node, defaultValue });

Styling warns it, but I think it's ok. What do you think about it?

[Darin Adler]

Comment on attachment 255394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255394&action=review

>> Source/JavaScriptCore/parser/Nodes.h:1794
>> +            m_targetPatterns.append(Entry{ bindingType, node, defaultValue });
> 
> Styling warns it, but I think it's ok. What do you think about it?

I think the style script doesn’t understand the code, but I agree it’s OK. However, we can write this an even better way now that we have improved Vector; the type can be omitted:

    m_targetPatterns.append({ bindingType, node, defaultValue });

[Yusuke Suzuki]

Comment on attachment 255394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255394&action=review

>>> Source/JavaScriptCore/parser/Nodes.h:1794
>>> +            m_targetPatterns.append(Entry{ bindingType, node, defaultValue });
>> 
>> Styling warns it, but I think it's ok. What do you think about it?
> 
> I think the style script doesn’t understand the code, but I agree it’s OK. However, we can write this an even better way now that we have improved Vector; the type can be omitted:
> 
>     m_targetPatterns.append({ bindingType, node, defaultValue });

Looks nice. I'll update it ;)

[Yusuke Suzuki]

Created attachment 255397 [details]
Patch

[Yusuke Suzuki]

The patch is ready.
Could anyone take a look?

[Yusuke Suzuki]

Could you take a look?

[Oliver Hunt]

Comment on attachment 255397 [details]
Patch

R=me

[Yusuke Suzuki]

Comment on attachment 255397 [details]
Patch

Thank you for your review, oliver@!

[WebKit Commit Bot]

Comment on attachment 255397 [details]
Patch

Clearing flags on attachment: 255397

Committed r185981: <http://trac.webkit.org/changeset/185981>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.