Bug 146203 – [WinCairo] WebDownload::initWithRequest is not implemented.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

The method WebDownload::initWithRequest is not implemented on WinCairo.

Created attachment 255344 [details]
Patch

[Alex Christensen]

Comment on attachment 255344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255344&action=review

Does this make it so we can finally download things from within WinLauncher?

> Source/WebKit/win/WebDownloadCurl.cpp:186
> +        // If destination is already set, we don't need to ask delegate.
> +        if (!m_destination.isEmpty())
> +            return;

Is this correct?  What if the destination is already set but we want to change it?

Created attachment 255367 [details]
Patch

(In reply to comment #2)
>

Thanks for reviewing :)
 
> 
> Does this make it so we can finally download things from within WinLauncher?
> 

Unfortunately, no. WinLauncher crashes for me when I try to download a link, but I don't think it would take much work to fix this crash and get downloading from WinLauncher to work.

> > Source/WebKit/win/WebDownloadCurl.cpp:186
> > +        // If destination is already set, we don't need to ask delegate.
> > +        if (!m_destination.isEmpty())
> > +            return;
> 
> Is this correct?  What if the destination is already set but we want to
> change it?

Good point, I removed this in the latest patch.

[Alex Christensen]

Comment on attachment 255367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255367&action=review

Let's fix that crash and get downloading working, then!

> Source/WebKit/win/ChangeLog:12
> +        (WebDownload::didReceiveResponse): Do not ask delegate for destination if already set.

Remove this line.

Created attachment 255369 [details]
Patch

(In reply to comment #5)
> Comment on attachment 255367 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255367&action=review
> 
> Let's fix that crash and get downloading working, then!
> 

I will try to debug the crash soon :)

[Alex Christensen]

Comment on attachment 255369 [details]
Patch

This looks good, but I don't think it should go in until we fix the crash that this makes possible.

(In reply to comment #8)
> Comment on attachment 255369 [details]
> Patch
> 
> This looks good, but I don't think it should go in until we fix the crash
> that this makes possible.

Thanks :) I believe WinLauncher crashes when downloading without this patch aswell. Is it OK if I commit this patch, and make a separate patch for the crash?

[Alex Christensen]

Comment on attachment 255369 [details]
Patch

Sure.

Committed r185868: <http://trac.webkit.org/changeset/185868>