Bug 146202 - REGRESSION(r182303): [GTK] Context menu API is broken since r182303
Summary: REGRESSION(r182303): [GTK] Context menu API is broken since r182303
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-06-22 05:06 PDT by Carlos Garcia Campos
Modified: 2015-06-22 05:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2015-06-22 05:08 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-06-22 05:06:27 PDT 
And we didn't notice it because context menu API tests are skipped (see https://bugs.webkit.org/show_bug.cgi?id=117689). The problem is that ContextMenuclient API changed in r182303, but we didn't notice it either, and the default handler for getContextMenuFromProposedMenu was executed. An override keyword would have caught this.
Comment 1 Carlos Garcia Campos 2015-06-22 05:08:44 PDT 
Created attachment 255343 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-22 05:10:46 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2015-06-22 05:43:26 PDT 
Committed r185825: <http://trac.webkit.org/changeset/185825>