RESOLVED FIXED 146197
[Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target
https://bugs.webkit.org/show_bug.cgi?id=146197
Summary [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox P...
mitz
Reported 2015-06-21 22:40:50 PDT
We don’t need to maintain a separate build target for installing the sandbox profiles into the override location.
Attachments
Part 1: prepare the Sandbox Profiles target (4.77 KB, patch)
2015-06-21 22:45 PDT, mitz
andersca: review+
mitz
Comment 1 2015-06-21 22:45:28 PDT
Created attachment 255338 [details] Part 1: prepare the Sandbox Profiles target
Daniel Bates
Comment 2 2015-06-22 09:28:57 PDT
Comment on attachment 255338 [details] Part 1: prepare the Sandbox Profiles target View in context: https://bugs.webkit.org/attachment.cgi?id=255338&action=review > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1 > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES)); I take it you meant to write "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of "INSTALL_PATH_ENGINEERING_BUILD_".
mitz
Comment 3 2015-06-22 09:30:18 PDT
(In reply to comment #2) > Comment on attachment 255338 [details] > Part 1: prepare the Sandbox Profiles target > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255338&action=review > > > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1 > > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES)); > > I take it you meant to write > "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of > "INSTALL_PATH_ENGINEERING_BUILD_". Good catch! Thank you.
mitz
Comment 4 2015-06-22 10:05:31 PDT
mitz
Comment 5 2015-06-22 21:11:45 PDT
Deleted the target in <http://trac.webkit.org/r185861>.
Note You need to log in before you can comment on or make changes to this bug.