Bug 146197 - [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target
Summary: [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox P...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-21 22:40 PDT by mitz
Modified: 2015-06-22 21:11 PDT (History)
3 users (show)

See Also:

Attachments
Part 1: prepare the Sandbox Profiles target (4.77 KB, patch)
2015-06-21 22:45 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2015-06-21 22:40:50 PDT 
We don’t need to maintain a separate build target for installing the sandbox profiles into the override location.
Comment 1 mitz 2015-06-21 22:45:28 PDT 
Created attachment 255338 [details]
Part 1: prepare the Sandbox Profiles target
Comment 2 Daniel Bates 2015-06-22 09:28:57 PDT 
Comment on attachment 255338 [details]
Part 1: prepare the Sandbox Profiles target

View in context: https://bugs.webkit.org/attachment.cgi?id=255338&action=review

> Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1
> +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES));

I take it you meant to write "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of "INSTALL_PATH_ENGINEERING_BUILD_".
Comment 3 mitz 2015-06-22 09:30:18 PDT 
(In reply to comment #2)
> Comment on attachment 255338 [details]
> Part 1: prepare the Sandbox Profiles target
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255338&action=review
> 
> > Source/WebKit2/Configurations/SandboxProfiles.xcconfig:1
> > +INSTALL_PATH = $(INSTALL_PATH_ENGINEERING_BUILD_$(WK_INSTALL_OVERRIDE_SANDBOX_PROFILES));
> 
> I take it you meant to write
> "INSTALL_PATH_WK_INSTALL_OVERRIDE_SANDBOX_PROFILES_" instead of
> "INSTALL_PATH_ENGINEERING_BUILD_".

Good catch! Thank you.
Comment 4 mitz 2015-06-22 10:05:31 PDT 
Committed attachment 255338 [details] in <http://trac.webkit.org/r185832>.
Comment 5 mitz 2015-06-22 21:11:45 PDT 
Deleted the target in <http://trac.webkit.org/r185861>.