Bug 14618 - REGRESSION(13464): drivehq.com login form doesn't work
Summary: REGRESSION(13464): drivehq.com login form doesn't work
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Alexey Proskuryakov
URL: http://www.drivehq.com/secure/LogonOp...
Keywords: Regression
Depends on:
Reported: 2007-07-14 07:10 PDT by Alexey Proskuryakov
Modified: 2007-07-15 09:50 PDT (History)
0 users

See Also:

proposed fix (3.24 KB, patch)
2007-07-14 07:27 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-07-14 07:10:10 PDT
Steps to reproduce:
1) Open bug URL.
2) Enter you login and password (free registration required).
3) Press Enter or click Login button.

Results: the login page reloads.

This regressed in r13464, because the <input type="submit" value=""> no longer gets a default title, and WebKit doesn't serialize submits with empty values (I've tracked this code back to revision 4!). Thus, one of the expected parts is now missing from submitted request, which makes the site unhappy.
Comment 1 Alexey Proskuryakov 2007-07-14 07:27:35 PDT
Created attachment 15515 [details]
proposed fix
Comment 2 mitz 2007-07-14 07:36:27 PDT
Comment on attachment 15515 [details]
proposed fix

Is an HTTP test required?
Comment 3 Alexey Proskuryakov 2007-07-14 08:06:43 PDT
I think a local test can be made, similar to fast/forms/form-data-encoding.html - but an HTTP one is more straightforward. And as a side effect, it adds some coverage for POST code path.
Comment 4 Darin Adler 2007-07-14 09:52:23 PDT
Comment on attachment 15515 [details]
proposed fix

Comment 5 Alexey Proskuryakov 2007-07-14 11:05:32 PDT
Committed revision 24288.