146162 – WKFrameInfo should have an accessor for the Frame's current security origin

Bug 146162 - WKFrameInfo should have an accessor for the Frame's current security origin

Summary: WKFrameInfo should have an accessor for the Frame's current security origin

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebKit2 (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Brady Eidson

URL:
Keywords:

Depends on:
Blocks:

Reported:	2015-06-19 14:26 PDT by Brady Eidson
Modified:	2015-06-23 10:29 PDT (History)
CC List:	6 users (show)

See Also:

Attachments
Patch v1 (26.95 KB, patch) 2015-06-19 14:28 PDT, Brady Eidson	beidson: review-	Details \| Formatted Diff \| Diff
Patch v2 (103.34 KB, patch) 2015-06-19 22:29 PDT, Brady Eidson	mitz: review+ buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (737.98 KB, application/zip) 2015-06-19 23:24 PDT, Build Bot	no flags	Details
EWS run (101.72 KB, patch) 2015-06-20 22:16 PDT, Brady Eidson	no flags	Details \| Formatted Diff \| Diff
New EWS run (114.43 KB, patch) 2015-06-22 17:19 PDT, Brady Eidson	no flags	Details \| Formatted Diff \| Diff
EWS + CQ (114.44 KB, patch) 2015-06-23 08:51 PDT, Brady Eidson	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Brady Eidson 2015-06-19 14:26:22 PDT

WKFrameInfo should have an accessor for the Frame's current security origin

This also involves promoting _WKSecurityOrigin SPI to WKSecurityOrigin API

Comment 1 Brady Eidson 2015-06-19 14:28:20 PDT

Created attachment 255225 [details]
Patch v1

Comment 2 WebKit Commit Bot 2015-06-19 14:29:43 PDT

Attachment 255225 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 mitz 2015-06-19 14:44:31 PDT

Comment on attachment 255225 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=255225&action=review

> Source/WebKit2/UIProcess/API/APIFrameInfo.cpp:37
> +    , m_securityOrigin(securityOrigin ? securityOrigin->isolatedCopy() : WebCore::SecurityOrigin::create(m_request.url()))

I don’t know why it’s correct to use the frame’s URL in this case. Since there exist frames where the URL differs from the security origin, this code makes it easy to do the wrong thing.

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:61
> +        _wkSecurityOrigin = adoptNS([[_WKSecurityOrigin alloc] _initWithSecurityOrigin:_frameInfo->securityOrigin()]);

We can make a WKSecurityOrigin here, I think, no need to make a _WKSecurityOrigin.

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:48
> +    RetainPtr<WKSecurityOrigin> _wkSecurityOrigin;

Hmm… we normally don’t give our wrappers extra ivars. I think we don’t need to have this cache.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:35
> + @discussion An instance of this class is a transient, data-only object;
> + it does not uniquely identify a security origin across multiple delegate method
> + calls.

Seems like we could easily implement -isEqual: and -hash here to make this comment unnecessary.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:40
> +@interface WKSecurityOrigin : NSObject <NSCopying>

Not sure we need NSCopying.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:30
> +#import <wtf/PassRefPtr.h>

Is this #import needed here?

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:33
> +class ResourceRequest;

This forward declaration is unused.

> Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.mm:34
>  @implementation _WKSecurityOrigin {
> -    RefPtr<WebCore::SecurityOrigin> _origin;
>  }

Can get rid of the braces as well.

Comment 4 Brady Eidson 2015-06-19 15:01:32 PDT

(In reply to comment #3)
> Comment on attachment 255225 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255225&action=review
> 
> > Source/WebKit2/UIProcess/API/APIFrameInfo.cpp:37
> > +    , m_securityOrigin(securityOrigin ? securityOrigin->isolatedCopy() : WebCore::SecurityOrigin::create(m_request.url()))
> 
> I don’t know why it’s correct to use the frame’s URL in this case. Since
> there exist frames where the URL differs from the security origin, this code
> makes it easy to do the wrong thing.

I believe it would be preventatively difficult to always have the correct security origin available in the UI process.

So we can either manufacture an origin that will be right most of the time, which is a lie...
Or we can optionally return a nil origin, which is wrong all of the time, because there actually is always an origin.

Is there another alternative I am missing?

> > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:61
> > +        _wkSecurityOrigin = adoptNS([[_WKSecurityOrigin alloc] _initWithSecurityOrigin:_frameInfo->securityOrigin()]);
> 
> We can make a WKSecurityOrigin here, I think, no need to make a
> _WKSecurityOrigin.

Right. Changed.

> > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:48
> > +    RetainPtr<WKSecurityOrigin> _wkSecurityOrigin;
> 
> Hmm… we normally don’t give our wrappers extra ivars. I think we don’t need
> to have this cache.

We wouldn't normally have an accessor return a different object each time you ask, either.

While the object is transient, data-only... it would be very strange to have the following:

// ... passed in some WKFrameInfo called 'frameInfo'
WKSecurityOrigin *origin1 [frameInfo securityOrigin];
WKSecurityOrigin *origin2 [frameInfo securityOrigin];
if (origin1 != origin2)
    NSLog(@"Huh?");

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:35
> > + @discussion An instance of this class is a transient, data-only object;
> > + it does not uniquely identify a security origin across multiple delegate method
> > + calls.
> 
> Seems like we could easily implement -isEqual: and -hash here to make this
> comment unnecessary.

I'm not sure the comment is about the lack of isEqual and hash. It's to stress that you shouldn't expect to get the same object across two delegate calls even if the underlying object has not actually changed.

FWIW, I cribbed this comment from WKFrameInfo which has the exact same consideration.

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:40
> > +@interface WKSecurityOrigin : NSObject <NSCopying>
> 
> Not sure we need NSCopying.

I suppose not. Removed

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:30
> > +#import <wtf/PassRefPtr.h>
> 
> Is this #import needed here?

No, sorry. Is needed somewhere else. This file changed over development.
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:33
> > +class ResourceRequest;
> 
> This forward declaration is unused.

Right. Also leftovers.

> > Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.mm:34
> >  @implementation _WKSecurityOrigin {
> > -    RefPtr<WebCore::SecurityOrigin> _origin;
> >  }
> 
> Can get rid of the braces as well.

Oh, maybe! Didn't even think to try.

Comment 5 Brady Eidson 2015-06-19 17:12:37 PDT

In person, discussed a few of these, came to good resolutions.

Next patch coming sometime soonish, in the next few days.

Comment 6 Brady Eidson 2015-06-19 22:29:32 PDT

Created attachment 255280 [details]
Patch v2

Comment 7 WebKit Commit Bot 2015-06-19 22:31:55 PDT

Attachment 255280 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:163:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:177:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:220:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 mitz 2015-06-19 22:55:03 PDT

Comment on attachment 255280 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=255280&action=review

r=me with minor comments below.

> Source/WebKit2/ChangeLog:10
> +        - Makes the WKSecurityOrigin Cocoa API object with with API::SecurityOrigin.

with with?

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:1852
> +        virtual void didFailProvisionalLoadInSubframeWithError(WebPageProxy& page, WebFrameProxy& subframe, const WebKit::SecurityOriginData& securityOriginData, API::Navigation* navigation, const WebCore::ResourceError& error, API::Object* userData) override

No need for WebKit:: here

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:32
> +#import "WKSecurityOriginInternal.h"
> +#import "_WKSecurityOrigin.h"

Do we need both of these?

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:32
> +#import "WKRetainPtr.h"

?

> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:88
> +    virtual void didPostMessage(WebKit::WebPageProxy& page, WebKit::WebFrameProxy& frame, const WebKit::SecurityOriginData& securityOriginData, WebCore::SerializedScriptValue& serializedScriptValue)

No need for WebKit:: here.

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:31
> +#import "APISecurityOrigin.h"

This is imported by WKSecurityOriginInternal.h below.

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:43
> +#import "_WKSecurityOrigin.h"

Still need this?

> Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:61
> +        virtual void didPostMessage(WebPageProxy&, WebFrameProxy&, const WebKit::SecurityOriginData&, WebCore::SerializedScriptValue&) = 0;

No need for WebKit:: here.

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:439
> +    SecurityOriginData originData;
> +    if (Document* document = frame->document()) {
> +        if (SecurityOrigin* origin = document->securityOrigin())
> +            originData = SecurityOriginData::fromSecurityOrigin(*origin);
> +    }
> +

Can pull this into a static function instead of repeating it four times?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:840
> +    SecurityOriginData originatingOriginData;
> +    if (Document* document = originatingFrame->coreFrame()->document()) {
> +        if (SecurityOrigin* origin = document->securityOrigin())
> +            originatingOriginData = SecurityOriginData::fromSecurityOrigin(*origin);
> +    }

Wow, even more of this. Maybe it can be a static function in SecurityOriginData?

Comment 9 Build Bot 2015-06-19 23:24:00 PDT

Comment on attachment 255280 [details]
Patch v2

Attachment 255280 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4569267521454080

New failing tests:
inspector/model/parse-script-syntax-tree.html
http/tests/inspector/css/bad-mime-type.html
inspector/css/matched-style-properties.html
inspector/console/console-api.html
http/tests/navigation/post-redirect-get-reload.php
inspector/event-listener.html
inspector/protocol-promise-result.html
inspector/console/console-table.html
fast/loader/onload-policy-ignore-for-frame.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
inspector/event-listener-set.html

Comment 10 Build Bot 2015-06-19 23:24:04 PDT

Created attachment 255281 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 11 Brady Eidson 2015-06-20 13:41:39 PDT

(In reply to comment #7)
> Attachment 255280 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before
> {  [whitespace/braces] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:123:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:143:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:157:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:163:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:177:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:220:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before (
> in function call  [whitespace/parens] [4]
> Total errors found: 26 in 38 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

These are all bull, as check-webkit-style does not understand C++ lambdas, etc

Comment 12 Brady Eidson 2015-06-20 13:42:13 PDT

(In reply to comment #8)
> Comment on attachment 255280 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255280&action=review
> 
> r=me with minor comments below.


I'll address all of these before landing.

Comment 13 Brady Eidson 2015-06-20 13:43:06 PDT

(In reply to comment #9)
> Comment on attachment 255280 [details]
> Patch v2
> 
> Attachment 255280 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/4569267521454080
> 
> New failing tests:
> inspector/model/parse-script-syntax-tree.html
> http/tests/inspector/css/bad-mime-type.html
> inspector/css/matched-style-properties.html
> inspector/console/console-api.html
> http/tests/navigation/post-redirect-get-reload.php
> inspector/event-listener.html
> inspector/protocol-promise-result.html
> inspector/console/console-table.html
> fast/loader/onload-policy-ignore-for-frame.html
> inspector/test-harness-trivially-works.html
> inspector/css/pseudo-element-matches.html
> inspector/css/selector-specificity.html
> fast/loader/window-open-to-invalid-url-disallowed.html
> fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
> inspector/event-listener-set.html

And... I'll make sure these aren't my-bad.

Comment 14 Brady Eidson 2015-06-20 22:16:10 PDT

Created attachment 255310 [details]
EWS run

Comment 15 WebKit Commit Bot 2015-06-20 22:17:39 PDT

Attachment 255310 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 16 Brady Eidson 2015-06-22 17:19:13 PDT

Created attachment 255379 [details]
New EWS run

Comment 17 WebKit Commit Bot 2015-06-22 17:22:15 PDT

Attachment 255379 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1411:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1422:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1145:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1146:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1147:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 18 Brady Eidson 2015-06-23 08:51:09 PDT

Created attachment 255413 [details]
EWS + CQ

Comment 19 WebKit Commit Bot 2015-06-23 08:52:55 PDT

Attachment 255413 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1411:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1422:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1145:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1146:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1147:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 20 Brady Eidson 2015-06-23 09:23:40 PDT

This test failure:
Regressions: Unexpected image-only failures (1)
  compositing/masks/compositing-clip-path-origin.html [ ImageOnlyFailure ]

is not from this patch...

Comment 21 WebKit Commit Bot 2015-06-23 10:29:09 PDT

Comment on attachment 255413 [details]
EWS + CQ

Clearing flags on attachment: 255413

Committed r185877: <http://trac.webkit.org/changeset/185877>

Comment 22 WebKit Commit Bot 2015-06-23 10:29:15 PDT

All reviewed patches have been landed.  Closing bug.