Bug 146146 - Fix the Windows build after r185721
Summary: Fix the Windows build after r185721
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 146118
  Show dependency treegraph
Reported: 2015-06-19 01:29 PDT by Csaba Osztrogonác
Modified: 2015-06-19 06:32 PDT (History)
7 users (show)

See Also:

Patch (1.65 KB, patch)
2015-06-19 05:42 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-19 01:29:16 PDT
https://trac.webkit.org/changeset/185721 broke the WinCairo build:

..\..\win\DumpRenderTree.cpp(1372): error C2259: 'UIDelegate' : cannot instantiate abstract class [C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\Tools\DumpRenderTree\DumpRenderTree.vcxproj\DumpRenderTree\DumpRenderTree.vcxproj]
          due to following members:
          'HRESULT IWebUIDelegatePrivate::unused4(void)' : is abstract
          C:\Users\Alex\Documents\WinCairoBot\win-cairo-release\build\WebKitBuild\Release_WinCairo\Include\WebKit/WebKit.h(33580) : see declaration of 'IWebUIDelegatePrivate::unused4'
Comment 1 Csaba Osztrogonác 2015-06-19 01:36:18 PDT
Not only the WinCairo build, but Apple Windows build is broken too:

But unfortunately you weren't able to notice it before 
landing, because Windows EWS is broken a week ago.
Comment 2 peavo 2015-06-19 04:58:37 PDT
I had the same problem as the Windows EWS locally, I had to run the command cpan LWP::Protocol::https from the shell.
Comment 3 peavo 2015-06-19 05:42:50 PDT
Created attachment 255188 [details]
Comment 4 Csaba Osztrogonác 2015-06-19 05:45:37 PDT
Comment on attachment 255188 [details]

Comment 5 peavo 2015-06-19 05:46:14 PDT
(In reply to comment #4)
> Comment on attachment 255188 [details]
> Patch
> rs=me

Comment 6 WebKit Commit Bot 2015-06-19 06:32:35 PDT
Comment on attachment 255188 [details]

Clearing flags on attachment: 255188

Committed r185747: <http://trac.webkit.org/changeset/185747>
Comment 7 WebKit Commit Bot 2015-06-19 06:32:41 PDT
All reviewed patches have been landed.  Closing bug.