Bug 146138 - Get CAContext directly for CALayer instead of walking the layer tree.
Summary: Get CAContext directly for CALayer instead of walking the layer tree.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-18 21:18 PDT by Jeremy Jones
Modified: 2015-06-19 12:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2015-06-18 21:21 PDT, Jeremy Jones 		darin: review+
Details | Formatted Diff | Diff
Patch for landing. (3.54 KB, patch)
2015-06-19 11:33 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-06-18 21:18:44 PDT 
Get CAContext directly for CALayer instead of walking the layer tree.
Comment 1 Jeremy Jones 2015-06-18 21:19:16 PDT 
rdar://problem/21455378
Comment 2 Jeremy Jones 2015-06-18 21:21:37 PDT 
Created attachment 255169 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-06-19 08:19:30 PDT 
Comment on attachment 255169 [details]
Patch

I can't review this without some more explanation in the changelog.
Comment 4 Darin Adler 2015-06-19 11:25:04 PDT 
Comment on attachment 255169 [details]
Patch

Seems clearly more efficient and straightforward. Does it also fix any bugs? Can we make a regression test for the bugs it fixes?
Comment 5 Jeremy Jones 2015-06-19 11:32:44 PDT 
(In reply to comment #4)
> Comment on attachment 255169 [details]
> Patch
> 
> Seems clearly more efficient and straightforward. Does it also fix any bugs?
> Can we make a regression test for the bugs it fixes?

I don't know of any concrete failures that this fixes, only the hunch that the convoluted approach might fail where the direct approach would succeed.
Comment 6 Jeremy Jones 2015-06-19 11:33:43 PDT 
Created attachment 255203 [details]
Patch for landing.
Comment 7 Jeremy Jones 2015-06-19 11:34:06 PDT 
(In reply to comment #3)
> Comment on attachment 255169 [details]
> Patch
> 
> I can't review this without some more explanation in the changelog.

Added more explanation.
Comment 8 WebKit Commit Bot 2015-06-19 12:29:36 PDT 
Comment on attachment 255203 [details]
Patch for landing.

Clearing flags on attachment: 255203

Committed r185763: <http://trac.webkit.org/changeset/185763>