Bug 146138 – Get CAContext directly for CALayer instead of walking the layer tree.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Get CAContext directly for CALayer instead of walking the layer tree.

[Jeremy Jones]

rdar://problem/21455378

[Jeremy Jones]

Created attachment 255169 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 255169 [details]
Patch

I can't review this without some more explanation in the changelog.

[Darin Adler]

Comment on attachment 255169 [details]
Patch

Seems clearly more efficient and straightforward. Does it also fix any bugs? Can we make a regression test for the bugs it fixes?

[Jeremy Jones]

(In reply to comment #4)
> Comment on attachment 255169 [details]
> Patch
> 
> Seems clearly more efficient and straightforward. Does it also fix any bugs?
> Can we make a regression test for the bugs it fixes?

I don't know of any concrete failures that this fixes, only the hunch that the convoluted approach might fail where the direct approach would succeed.

[Jeremy Jones]

Created attachment 255203 [details]
Patch for landing.

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 255169 [details]
> Patch
> 
> I can't review this without some more explanation in the changelog.

Added more explanation.

[WebKit Commit Bot]

Comment on attachment 255203 [details]
Patch for landing.

Clearing flags on attachment: 255203

Committed r185763: <http://trac.webkit.org/changeset/185763>