Bug 146131 - Migrate break_lines.h to unsigned optionals
Summary: Migrate break_lines.h to unsigned optionals
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 16:58 PDT by Myles C. Maxfield
Modified: 2015-08-24 11:55 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-06-18 16:58:12 PDT 
Currently, we use ints with a -1 sentinel value. Instead, we should implement a special unsigned optional type which still uses -1 as its sentinel (because using a regular optional would cause a performance regression)
Comment 1 Myles C. Maxfield 2015-08-24 11:55:02 PDT 
Look at m_nextBreakablePosition in InlineIterator