Bug 146124 – Spintracer treats the web process as hung when it's showing JavaScript dialogs in the UI process

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Spintracer treats the web process as hung when it's showing JavaScript dialogs in the UI process

[Anders Carlsson]

Created attachment 255136 [details]
Patch

[Geoffrey Garen]

Comment on attachment 255136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255136&action=review

> Source/WebKit2/Shared/mac/HangDetectionDisablerMac.mm:38
> +    if (CGSCopyConnectionProperty(CGSMainConnectionID(), CGSMainConnectionID(), clientsMayIgnoreEventsKey, &value) != kCGErrorSuccess)

Shouldn't we CFRelease value after this copy? Maybe use RetainPtr here?

> Source/WebKit2/Shared/mac/WebMemorySampler.mac.mm:-32
> -#import "config.h"
> -#import "WebMemorySampler.h"
> -
> -#if ENABLE(MEMORY_SAMPLER)  
> -
> -#import <JavaScriptCore/MemoryStatistics.h>
> -#import <mach/mach.h>

Revert?

[Anders Carlsson]

Created attachment 255138 [details]
Patch

[Anders Carlsson]

Created attachment 255139 [details]
Patch

[Geoffrey Garen]

Comment on attachment 255139 [details]
Patch

r=me

[Alexey Proskuryakov]

Nice! Do you plan to adopt this for sync XHR, or would you like us to keep receiving reports about those?

[David Kilzer (:ddkilzer)]

<rdar://problem/21449395>

[Anders Carlsson]

(In reply to comment #6)
> Nice! Do you plan to adopt this for sync XHR, or would you like us to keep
> receiving reports about those?

I talked to Gavin about doing it - it's definitely something we should do. Same thing for window.print.

[Anders Carlsson]

Committed r185749: <http://trac.webkit.org/changeset/185749>

[Darin Adler]

Comment on attachment 255139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255139&action=review

> Source/WebKit2/Shared/mac/HangDetectionDisablerMac.mm:47
> +    auto value = adoptCF(valuePtr);
> +
> +    if (!value || CFGetTypeID(value.get()) != CFBooleanGetTypeID())
> +        return false;
> +
> +    return value == kCFBooleanTrue;

I think this one line does the same thing as the above four lines of code.

    return adoptCF(valuePtr) == kCFBooleanTrue;