Bug 146112 - ~4% Membuster regression after WebKit r185452
Summary: ~4% Membuster regression after WebKit r185452
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 146544
Blocks:
  Show dependency tree / graph
 
Reported: 2015-06-18 08:34 PDT by Antti Koivisto
Modified: 2015-07-02 05:11 PDT (History)
4 users (show)

See Also:

Attachments
patch (4.78 KB, patch)
2015-06-18 09:24 PDT, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2015-06-18 08:34:20 PDT 
Looks like delaying writes in disk cache increased memory consumption in Membuster, probably due to keeping write buffers around longer.
Comment 1 Antti Koivisto 2015-06-18 09:24:45 PDT 
Created attachment 255118 [details]
patch
Comment 2 Antti Koivisto 2015-06-18 09:25:13 PDT 
rdar://problem/21406677
Comment 3 Chris Dumez 2015-06-18 09:34:54 PDT 
Comment on attachment 255118 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255118&action=review

r=me

> Source/WebKit2/ChangeLog:8
> +        Clear the cache write queue on critical memory pressure. There can be substantial amount of memory there and we

I thought you were going to hurry the writes instead but why not. This is much simpler :)

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:184
> +

nit: Seems unnecessary to add a line here.
Comment 4 Antti Koivisto 2015-06-18 10:17:47 PDT 
https://trac.webkit.org/r185704
Comment 5 WebKit Commit Bot 2015-07-02 05:11:01 PDT 
Re-opened since this is blocked by bug 146544