Bug 146105 - Remove the useless LayoutTests/platform/wincairo/TestExpectations file
Summary: Remove the useless LayoutTests/platform/wincairo/TestExpectations file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-18 03:19 PDT by Csaba Osztrogonác
Modified: 2015-06-19 11:58 PDT (History)
8 users (show)

See Also:


Attachments
Patch (114.69 KB, patch)
2015-06-18 03:21 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-18 03:19:02 PDT
WinCairo buildbot does't run layout tests long long time ago ( http://trac.webkit.org/changeset/159815 )
because (N)RWT doesn't support this platform at all.

But folks regularly update LayoutTests/platform/wincairo/TestExpectations for nothing. We 
should simply remove this useless file since there is no way to run layout tests on WinCairo.
Comment 1 Csaba Osztrogonác 2015-06-18 03:21:56 PDT
Created attachment 255103 [details]
Patch
Comment 2 peavo 2015-06-18 04:20:20 PDT
I've been planning to look at the layout tests for WinCairo for some time, but I haven't had time for it yet. Maybe we can leave the file for now, or we can readd it once we get to work on the layout tests?
Comment 3 Csaba Osztrogonác 2015-06-18 04:47:25 PDT
(In reply to comment #2)
> I've been planning to look at the layout tests for WinCairo for some time,
> but I haven't had time for it yet. Maybe we can leave the file for now, or
> we can readd it once we get to work on the layout tests?

This file is very very outdated, nobody ran layout tests on WinCairo
in the latest 2-3 years. I proposed removing it to avoid useless
speculative changes in it. 

Of course it would be great if somebody could make layout testing work
on WinCairo port work and maintain TestExpectations and expected files too.
Comment 4 peavo 2015-06-18 05:32:07 PDT
Yes, I will hopefully have some time to look at the http and layout tests soon :)
Comment 5 Darin Adler 2015-06-19 11:08:15 PDT
Comment on attachment 255103 [details]
Patch

Yes, we can make a new one some day or even pull this file out of Subversion history.
Comment 6 WebKit Commit Bot 2015-06-19 11:57:59 PDT
Comment on attachment 255103 [details]
Patch

Clearing flags on attachment: 255103

Committed r185758: <http://trac.webkit.org/changeset/185758>
Comment 7 WebKit Commit Bot 2015-06-19 11:58:04 PDT
All reviewed patches have been landed.  Closing bug.