RESOLVED FIXED 146105
Remove the useless LayoutTests/platform/wincairo/TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=146105
Summary Remove the useless LayoutTests/platform/wincairo/TestExpectations file
Csaba Osztrogonác
Reported 2015-06-18 03:19:02 PDT
WinCairo buildbot does't run layout tests long long time ago ( http://trac.webkit.org/changeset/159815 ) because (N)RWT doesn't support this platform at all. But folks regularly update LayoutTests/platform/wincairo/TestExpectations for nothing. We should simply remove this useless file since there is no way to run layout tests on WinCairo.
Attachments
Patch (114.69 KB, patch)
2015-06-18 03:21 PDT, Csaba Osztrogonác
no flags
Csaba Osztrogonác
Comment 1 2015-06-18 03:21:56 PDT
peavo
Comment 2 2015-06-18 04:20:20 PDT
I've been planning to look at the layout tests for WinCairo for some time, but I haven't had time for it yet. Maybe we can leave the file for now, or we can readd it once we get to work on the layout tests?
Csaba Osztrogonác
Comment 3 2015-06-18 04:47:25 PDT
(In reply to comment #2) > I've been planning to look at the layout tests for WinCairo for some time, > but I haven't had time for it yet. Maybe we can leave the file for now, or > we can readd it once we get to work on the layout tests? This file is very very outdated, nobody ran layout tests on WinCairo in the latest 2-3 years. I proposed removing it to avoid useless speculative changes in it. Of course it would be great if somebody could make layout testing work on WinCairo port work and maintain TestExpectations and expected files too.
peavo
Comment 4 2015-06-18 05:32:07 PDT
Yes, I will hopefully have some time to look at the http and layout tests soon :)
Darin Adler
Comment 5 2015-06-19 11:08:15 PDT
Comment on attachment 255103 [details] Patch Yes, we can make a new one some day or even pull this file out of Subversion history.
WebKit Commit Bot
Comment 6 2015-06-19 11:57:59 PDT
Comment on attachment 255103 [details] Patch Clearing flags on attachment: 255103 Committed r185758: <http://trac.webkit.org/changeset/185758>
WebKit Commit Bot
Comment 7 2015-06-19 11:58:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.