I think it'd be nice to use the names the spec uses on this. Any objections?
Created attachment 255931 [details] patch My motivation for this is the difference between these two google searches https://www.google.com/search?client=safari&rls=en&q=deconstruction+pattern+javasript&ie=UTF-8&oe=UTF-8 https://www.google.com/search?client=safari&rls=en&q=destructuring+pattern+javascript&ie=UTF-8&oe=UTF-8
Please rebase the patch.
Created attachment 255965 [details] patch
Attachment 255965 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/parser/NodeConstructors.h:830: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 255965 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=255965&action=review r=me with suggested fix. > Source/JavaScriptCore/parser/NodeConstructors.h:830 > - inline ParameterNode::ParameterNode(ParameterNode* l, PassRefPtr<DeconstructionPatternNode> pattern) > + inline ParameterNode::ParameterNode(ParameterNode* l, PassRefPtr<DestructuringPatternNode> pattern) I know this is not your doing, but since you’re touching this code, would you mind renaming “l” here to something like “lastParam” to please the style checker. I’m guessing that’s the intended meaning of “l”?
Created attachment 256034 [details] patch With renamed parameter
Comment on attachment 256034 [details] patch Clearing flags on attachment: 256034 Committed r186246: <http://trac.webkit.org/changeset/186246>
All reviewed patches have been landed. Closing bug.