Bug 146080 – Web Inspector: Fix shape-highlight layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Currently, the tests in LayoutTests/inspector/dom/ are failing with unknown errors.  These fixes are expecting the changes in https://bugs.webkit.org/show_bug.cgi?id=145658 to be made.

[Devin Rousso]

Created attachment 255040 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 255040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255040&action=review

> Source/WebCore/inspector/InspectorOverlay.cpp:668
> -            shapeObject->setMarginShape(shapePath.copyRef());
> +            shapeObject->setMarginShape(marginShapePath.copyRef());

Yay!

> LayoutTests/http/tests/inspector/dom/shapes-test.js:35
> +            InspectorTest.assert(!error, "When evaluating code, received unexpected error:" + error);
> +            InspectorTest.assert(!error, "When evaluating code, an exception was thrown:" + wasThrown);

Missing LayoutTests/ChangeLog entry for the updates to this file. r- so you can add a changelog. Otherwise the patch looks great!

[Devin Rousso]

Created attachment 255041 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 255041 [details]
Patch

r=me

[Radar WebKit Bug Importer]

<rdar://problem/21752788>

[WebKit Commit Bot]

Comment on attachment 255041 [details]
Patch

Rejecting attachment 255041 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 255041 [details]
Patch

Clearing flags on attachment: 255041

Committed r186639: <http://trac.webkit.org/changeset/186639>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.