Bug 146061 - [CSS Grid Layout] Performance tests are using the old syntax
Summary: [CSS Grid Layout] Performance tests are using the old syntax
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
Depends on:
Blocks: 127987
  Show dependency treegraph
Reported: 2015-06-17 07:57 PDT by Javier Fernandez
Modified: 2015-06-17 09:14 PDT (History)
5 users (show)

See Also:

Patch (1.99 KB, patch)
2015-06-17 08:01 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2015-06-17 07:57:14 PDT
Somehow we forgot to update the Grid Layout performance tests when tracks definition syntax changed. Currently they are using grid-definition-{rows, columns} instead if what current official draft is specifying, grid-template-{rows, columns}.
Comment 1 Javier Fernandez 2015-06-17 08:01:08 PDT
Created attachment 255015 [details]
Comment 2 Sergio Villar Senin 2015-06-17 08:25:16 PDT
Comment on attachment 255015 [details]

What a mistake! Nice catch!
Comment 3 WebKit Commit Bot 2015-06-17 09:14:31 PDT
Comment on attachment 255015 [details]

Clearing flags on attachment: 255015

Committed r185652: <http://trac.webkit.org/changeset/185652>
Comment 4 WebKit Commit Bot 2015-06-17 09:14:35 PDT
All reviewed patches have been landed.  Closing bug.