Bug 146057 - [GTK] [Wayland] Build by default the X11 and Wayland targets.
Summary: [GTK] [Wayland] Build by default the X11 and Wayland targets.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on: 145701 146056 146740 147559
Blocks: 81456
  Show dependency tree / graph
 
Reported: 2015-06-17 05:10 PDT by Carlos Alberto Lopez Perez
Modified: 2015-08-03 08:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2015-07-13 17:45 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2015-07-13 18:21 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2015-06-17 05:10:52 PDT 
In order to give proper testing to the Wayland target, enable building by default both the X11 and Wayland targets on the GTK port.
Comment 1 Carlos Alberto Lopez Perez 2015-07-13 17:41:32 PDT 
I have tested the following:

 - build the x11 targets alone (current default) and run the layout tests twice to discard flaky tests.
 - build both targets (x11 and wayland) and run the layout tests (for xvfb/x11) twice to discard flaky tests.

  + compare the results in both cases: I don't observe differences.


So, I will upload a patch for review turning on the switch.
Comment 2 Carlos Alberto Lopez Perez 2015-07-13 17:45:33 PDT 
Created attachment 256749 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2015-07-13 18:21:09 PDT 
Created attachment 256754 [details]
Patch

Add headers of wayland to script install-dependencies.
Comment 4 Michael Catanzaro 2015-07-13 19:25:45 PDT 
:)
Comment 5 Carlos Alberto Lopez Perez 2015-07-14 01:47:14 PDT 
Comment on attachment 256754 [details]
Patch

Clearing flags on attachment: 256754

Committed r186800: <http://trac.webkit.org/changeset/186800>
Comment 6 Carlos Alberto Lopez Perez 2015-07-14 01:47:22 PDT 
All reviewed patches have been landed.  Closing bug.