RESOLVED FIXED 146034
Move LocalStorageDetails into the local storage database tracker 
https://bugs.webkit.org/show_bug.cgi?id=146034
Summary Move LocalStorageDetails into the local storage database tracker
Anders Carlsson
Reported 2015-06-16 16:03:13 PDT
Move LocalStorageDetails into the local storage database tracker
Attachments
Patch (15.65 KB, patch)
2015-06-16 16:09 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-06-16 16:09:41 PDT
Created attachment 254973 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-16 16:10:47 PDT
Attachment 254973 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:626: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2015-06-16 16:13:48 PDT
Comment on attachment 254973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254973&action=review r=me > Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp:130 > - storageManager->deleteAllLocalStorageEntries(); > + storageManager->deleteLocalStorageOriginsModifiedSince(std::chrono::system_clock::time_point::min(), [] { }); The old version read slightly nicer :| > Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.h:68 > + Vector<OriginDetails> originDetails(); const?
Anders Carlsson
Comment 4 2015-06-16 16:31:28 PDT
Committed r185625: <http://trac.webkit.org/changeset/185625>
Note You need to log in before you can comment on or make changes to this bug.