Bug 146034 - Move LocalStorageDetails into the local storage database tracker
Summary: Move LocalStorageDetails into the local storage database tracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-16 16:03 PDT by Anders Carlsson
Modified: 2015-06-16 16:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.65 KB, patch)
2015-06-16 16:09 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-06-16 16:03:13 PDT 
Move LocalStorageDetails into the local storage database tracker
Comment 1 Anders Carlsson 2015-06-16 16:09:41 PDT 
Created attachment 254973 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-16 16:10:47 PDT 
Attachment 254973 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:72:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:626:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-06-16 16:13:48 PDT 
Comment on attachment 254973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254973&action=review

r=me

> Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp:130
> -    storageManager->deleteAllLocalStorageEntries();
> +    storageManager->deleteLocalStorageOriginsModifiedSince(std::chrono::system_clock::time_point::min(), [] { });

The old version read slightly nicer :|

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.h:68
> +    Vector<OriginDetails> originDetails();

const?
Comment 4 Anders Carlsson 2015-06-16 16:31:28 PDT 
Committed r185625: <http://trac.webkit.org/changeset/185625>