Bug 146027 – WebResourceCacheManager is unused, get rid of it

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

WebResourceCacheManager is unused, get rid of it

[Anders Carlsson]

Created attachment 254967 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254967 [details]
Patch

Clearing flags on attachment: 254967

Committed r185615: <http://trac.webkit.org/changeset/185615>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Alberto Lopez Perez]

This was used by the GTK port in webkit_web_context_clear_cache() at Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp

Now the GTK build is broken :(

I don't think is so hard to use a tool like grep in order to check no other ports are using the code you are removing, isn't it?

[Anders Carlsson]

(In reply to comment #4)
> This was used by the GTK port in webkit_web_context_clear_cache() at
> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
> 
> Now the GTK build is broken :(
> 
> I don't think is so hard to use a tool like grep in order to check no other
> ports are using the code you are removing, isn't it?

https://lists.webkit.org/pipermail/webkit-dev/2013-January/023255.html

[Anders Carlsson]

(In reply to comment #5)
> (In reply to comment #4)
> > This was used by the GTK port in webkit_web_context_clear_cache() at
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
> > 
> > Now the GTK build is broken :(
> > 
> > I don't think is so hard to use a tool like grep in order to check no other
> > ports are using the code you are removing, isn't it?
> 
> https://lists.webkit.org/pipermail/webkit-dev/2013-January/023255.html

(You can easily reimplement the webkit_web_context_clear_cache functionality in terms of WebsiteDataStore).

[Carlos Alberto Lopez Perez]

Landed quick build fix on https://trac.webkit.org/r185634 and opened bug 146041 for bringing back the functionality.