As stated here http://dev.w3.org/csswg/css-grid/#min-size-auto
We need to merge the following Blink changes: - https://crrev.com/194408 - https://crrev.com/194863 - https://crrev.com/194887 (partially)
Also this one https://src.chromium.org/viewvc/blink?view=revision&revision=201797
(In reply to comment #2) > Also this one > https://src.chromium.org/viewvc/blink?view=revision&revision=201797 We'll merge that later once we have the alignment logic in place.
Created attachment 260852 [details] Patch
Created attachment 261005 [details] Rebased patch
Comment on attachment 261005 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=261005&action=review > Source/WebCore/rendering/RenderBox.cpp:2757 > + if (Optional<LayoutUnit> minContentHeight = computeContentLogicalHeight(MinSize, Length(MinContent), computedValues.m_extent - borderAndPaddingLogicalHeight())) > + contentHeight = std::max(contentHeight, constrainLogicalHeightByMinMax(minContentHeight.value(), computedValues.m_extent - borderAndPaddingLogicalHeight())); Put the repeated expression computedValues.m_extent - borderAndPaddingLogicalHeight() into a local variable? Might also want to use auto instead of explicitly stating Optional<LayoutUnit>.
Comment on attachment 261005 [details] Rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=261005&action=review >> Source/WebCore/rendering/RenderBox.cpp:2757 >> + contentHeight = std::max(contentHeight, constrainLogicalHeightByMinMax(minContentHeight.value(), computedValues.m_extent - borderAndPaddingLogicalHeight())); > > Put the repeated expression computedValues.m_extent - borderAndPaddingLogicalHeight() into a local variable? > > Might also want to use auto instead of explicitly stating Optional<LayoutUnit>. Sure, I'll do.
Committed r189708: <http://trac.webkit.org/changeset/189708>