Bug 146005 - Add test expectations for El Capitan
Summary: Add test expectations for El Capitan
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-15 22:05 PDT by Alexey Proskuryakov
Modified: 2015-08-28 18:58 PDT (History)
5 users (show)

See Also:

Attachments
proposed patch (815.84 KB, patch)
2015-06-15 22:12 PDT, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-06-15 22:05:44 PDT 
Add test expectations and most tools code. What's left out is WebKitSystemInterface and LLVM binaries support.
Comment 1 Alexey Proskuryakov 2015-06-15 22:12:41 PDT 
Created attachment 254934 [details]
proposed patch
Comment 2 mitz 2015-06-15 22:25:47 PDT 
Comment on attachment 254934 [details]
proposed patch

I looked briefly at the tools changes and they seemed sane.
rs=me
Comment 3 Alexey Proskuryakov 2015-06-15 22:48:37 PDT 
Committed <http://trac.webkit.org/r185581>.
Comment 4 Tim Horton 2015-08-28 18:56:26 PDT 
Comment on attachment 254934 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254934&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:212
> +        'Mac', 'SnowLeopard', 'Lion', 'MountainLion', 'Mavericks', 'Yosemite', 'ElCapitan'

There's a missing comma at the end of the line here. How is this not causing more trouble?
Comment 5 Tim Horton 2015-08-28 18:58:44 PDT 
(In reply to comment #4)
> Comment on attachment 254934 [details]
> proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254934&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:212
> > +        'Mac', 'SnowLeopard', 'Lion', 'MountainLion', 'Mavericks', 'Yosemite', 'ElCapitan'
> 
> There's a missing comma at the end of the line here. How is this not causing
> more trouble?

Fixed in http://trac.webkit.org/changeset/189137