Bug 145998 – [iOS] Canvas dimensions should be limited to 4096x4096 pixels on iOS devices

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Said Abou-Hallawa]

Currently the Canvas size is limited to 256 Mega pixels (1 GB) on all platforms. The dimensions should be limited to 16 Mega pixels (64 MB) if the physical memory is less than 1 GB.

[Said Abou-Hallawa]

Created attachment 254919 [details]
Patch

[Build Bot]

Comment on attachment 254919 [details]
Patch

Attachment 254919 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5345401934708736

New failing tests:
canvas/drawing/image-create-limit-size.html
fast/canvas/pattern-too-large-to-create.html
fast/canvas/canvas-toDataURL-crash.html

[Build Bot]

Created attachment 254921 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 254919 [details]
Patch

Attachment 254919 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5842414476460032

New failing tests:
canvas/drawing/image-create-limit-size.html
fast/canvas/pattern-too-large-to-create.html
fast/canvas/canvas-toDataURL-crash.html

[Build Bot]

Created attachment 254923 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Said Abou-Hallawa]

Created attachment 254925 [details]
Patch

[Gavin Barraclough]

Comment on attachment 254925 [details]
Patch

I've commented in radar already, so will keep comment here brief.

16384x16384 seems to be way too high on iOS, even for 1GB and 2GB device (since this would allow a canvas larger than the per-process memory limit). I'd suggest 4096x4096 for all iOS devices (and 16384x16384 seems high for other platforms, too).

[Said Abou-Hallawa]

Created attachment 254955 [details]
Patch

[Said Abou-Hallawa]

Created attachment 254956 [details]
Patch

[Said Abou-Hallawa]

<rdar://problem/21382003>

[Said Abou-Hallawa]

Created attachment 254959 [details]
Patch

[Said Abou-Hallawa]

The new patch changes the line number of the log message in the test expected result. This happened because of deleting an invalid comment from the test.

[WebKit Commit Bot]

Comment on attachment 254959 [details]
Patch

Clearing flags on attachment: 254959

Committed r185603: <http://trac.webkit.org/changeset/185603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.