Bug 145993 – IDB: Records table migration doesn't work with all versions of SQLite

• Status: ASSIGNED
• Component: WebKit Misc.

[Brady Eidson]

IDB: Records table migration doesn't work with all versions of SQLite

Getting the current Records table schema from the sqlite_master table does not necessarily return the exact SQL used to create the table.

Some SQLites will return a quoted table name in the returned SQL, and others will have the table name be unquoted.

In the createOrMigrateRecordsTableIfNecessary() function we should check for both the quoted and unquoted schemas.

[Brady Eidson]

Created attachment 254907 [details]
Patch v1

[Jon Lee]

Comment on attachment 254907 [details]
Patch v1

Provisional r=me

[Jon Lee]

CC'ing some folks who might be able to give a real r+.

[Darin Adler]

Comment on attachment 254907 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=254907&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:63
> +    StringBuilder builder;
> +    builder.appendLiteral("CREATE TABLE ");
> +    builder.append(tableName);
> +    builder.appendLiteral(" (objectStoreID INTEGER NOT NULL ON CONFLICT FAIL, key TEXT COLLATE IDBKEY NOT NULL ON CONFLICT FAIL UNIQUE ON CONFLICT REPLACE, value NOT NULL ON CONFLICT FAIL)");
> +    return builder.toString();

This is something that would be more efficient with just the "+" operator or makeString rather than a StringBuilder.

[Brady Eidson]

Created attachment 254957 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 254957 [details]
Patch for landing

Rejecting attachment 254957 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 254957, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6073680211738624

[Brady Eidson]

(In reply to comment #6)
> Comment on attachment 254957 [details]
> Patch for landing
> 
> Rejecting attachment 254957 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02',
> 'validate-changelog', '--check-oops', '--non-interactive', 254957,
> '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid
> reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case
> insensitive).
> 

Wrong. Thanks, tools.

[Brady Eidson]

Created attachment 254958 [details]
Patch for landing v2

[Brady Eidson]

rdar://problem/17357002

[WebKit Commit Bot]

Comment on attachment 254958 [details]
Patch for landing v2

Clearing flags on attachment: 254958

Committed r185599: <http://trac.webkit.org/changeset/185599>