Bug 145967 - Fix build break when ENABLE_SECCOMP_FILTERS is ON
Summary: Fix build break when ENABLE_SECCOMP_FILTERS is ON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 144096
  Show dependency tree / graph
 
Reported: 2015-06-15 03:38 PDT by Ryuan Choi
Modified: 2015-06-15 15:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2015-06-15 03:45 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-06-15 03:38:57 PDT 
../../Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp: In member function ‘virtual void WebKit::OpenSyscallResult::encode(IPC::ArgumentEncoder&) const’:
../../Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp:203:41: error: cannot bind ‘IPC::Attachment’ lvalue to ‘IPC::Attachment&&’
         encoder.addAttachment(attachment);
                                         ^
In file included from ../../Source/WebKit2/Platform/IPC/ArgumentCoders.h:30:0,
                 from ../../Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp:31:
../../Source/WebKit2/Platform/IPC/ArgumentEncoder.h:68:10: error:   initializing argument 1 of ‘void IPC::ArgumentEncoder::addAttachment(IPC::Attachment&&)’
     void addAttachment(Attachment&&);
          ^
ninja: build stopped: subcommand failed.
Comment 1 Ryuan Choi 2015-06-15 03:45:29 PDT 
Created attachment 254868 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-06-15 08:50:51 PDT 
Comment on attachment 254868 [details]
Patch

Oops, sorry about this.
Comment 3 WebKit Commit Bot 2015-06-15 15:27:40 PDT 
Comment on attachment 254868 [details]
Patch

Clearing flags on attachment: 254868

Committed r185568: <http://trac.webkit.org/changeset/185568>
Comment 4 WebKit Commit Bot 2015-06-15 15:27:46 PDT 
All reviewed patches have been landed.  Closing bug.