https://streams.spec.whatwg.org/#request-readable-stream-pull should be implemented.
Created attachment 254879 [details] Patch before additional tests
Created attachment 254938 [details] Rebasing with new tests
Comment on attachment 254938 [details] Rebasing with new tests View in context: https://bugs.webkit.org/attachment.cgi?id=254938&action=review > Source/WebCore/Modules/streams/ReadableStream.h:122 > + bool m_isPullRequested { false }; Normally we try to make these things work grammatically. I don’t understand what “readable stream is pull requested” means. So I would expect this to have some other name, like “hasRequestedPull” or whatever would be the colloquial or standards language way for talking about the state of the stream.
(In reply to comment #3) > Comment on attachment 254938 [details] > Rebasing with new tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254938&action=review > > > Source/WebCore/Modules/streams/ReadableStream.h:122 > > + bool m_isPullRequested { false }; > > Normally we try to make these things work grammatically. I don’t understand > what “readable stream is pull requested” means. So I would expect this to > have some other name, like “hasRequestedPull” or whatever would be the > colloquial or standards language way for talking about the state of the > stream. OK. stream spec is now using "pullAgain". Let's call it "shouldPullAgain" then.
Created attachment 255003 [details] Patch for landing
Comment on attachment 255003 [details] Patch for landing Clearing flags on attachment: 255003 Committed r185648: <http://trac.webkit.org/changeset/185648>
All reviewed patches have been landed. Closing bug.