Bug 145963 - [ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Summary: [ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-14 10:27 PDT by Yusuke Suzuki
Modified: 2015-06-15 19:12 PDT (History)
9 users (show)

See Also:

Attachments
Patch (78.19 KB, patch)
2015-06-14 11:43 PDT, Yusuke Suzuki 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-06-14 10:27:19 PDT 
[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
Comment 1 Yusuke Suzuki 2015-06-14 11:43:13 PDT 
Created attachment 254862 [details]
Patch
Comment 2 Darin Adler 2015-06-15 10:47:32 PDT 
Comment on attachment 254862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review

> Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38
> +namespace JSC {
> +
> +}

Not sure what this is; but should probably remove it.
Comment 3 Yusuke Suzuki 2015-06-15 10:50:27 PDT 
Comment on attachment 254862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254862&action=review

Thanks!

>> Source/JavaScriptCore/runtime/IteratorPrototype.cpp:38
>> +}
> 
> Not sure what this is; but should probably remove it.

OK, dropped :D.
This block is originally introduced for definining forward declaration for XXX.prototype.xxx methods. (like `static EncodedJSValue JSC_HOST_CALL arrayIteratorProtoFuncIterator(ExecState*);`)
Comment 4 Yusuke Suzuki 2015-06-15 19:12:26 PDT 
Committed r185577: <http://trac.webkit.org/changeset/185577>