Bug 145960 – Format string misuse in DatabaseProcessIDBConnection.cpp and UniqueIDBDatabaseBackingStoreSQLite.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Michael Catanzaro]

Tons of format string warnings in DatabaseProcessIDBConnection.cpp and UniqueIDBDatabaseBackingStoreSQLite.cpp:

[2523/2953] Building CXX object Source...dDB/DatabaseProcessIDBConnection.cpp.o
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:82:99: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess getOrEstablishIDBDatabaseMetadata request ID %llu (connection %p)", requestID, this);
                                                                           ~~~~                   ^~~~~~~~~
                                                                           %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:94:80: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteDatabase request ID %llu (connection %p)", requestID, this);
                                                        ~~~~                   ^~~~~~~~~
                                                        %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:128:87: warning: format specifies type 'unsigned long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess openTransaction id %llu in mode '%s', request ID %llu", transactionID, modeString, requestID);
                                                 ~~~~                                 ^~~~~~~~~~~~~
                                                 %ld
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:128:114: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess openTransaction id %llu in mode '%s', request ID %llu", transactionID, modeString, requestID);
                                                                               ~~~~                              ^~~~~~~~~
                                                                               %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:147:66: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess beginTransaction request ID %llu", requestID);
                                                          ~~~~   ^~~~~~~~~
                                                          %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:159:67: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess commitTransaction request ID %llu", requestID);
                                                           ~~~~   ^~~~~~~~~
                                                           %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:171:66: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess resetTransaction request ID %llu", requestID);
                                                          ~~~~   ^~~~~~~~~
                                                          %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:183:69: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess rollbackTransaction request ID %llu", requestID);
                                                             ~~~~   ^~~~~~~~~
                                                             %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:213:89: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess changeDatabaseVersion request ID %llu, new version %llu", requestID, newVersion);
                                                               ~~~~                     ^~~~~~~~~
                                                               %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:213:100: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess changeDatabaseVersion request ID %llu, new version %llu", requestID, newVersion);
                                                                                 ~~~~              ^~~~~~~~~~
                                                                                 %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:225:91: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess createObjectStore request ID %llu, object store name '%s'", requestID, metadata.name.utf8().data());
                                                           ~~~~                           ^~~~~~~~~
                                                           %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:236:89: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteObjectStore request ID %llu, object store id %lli", requestID, objectStoreID);
                                                           ~~~~                         ^~~~~~~~~
                                                           %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:236:100: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteObjectStore request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                                 ~~~~              ^~~~~~~~~~~~~
                                                                                 %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:247:88: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess clearObjectStore request ID %llu, object store id %lli", requestID, objectStoreID);
                                                          ~~~~                         ^~~~~~~~~
                                                          %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:247:99: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess clearObjectStore request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                                ~~~~              ^~~~~~~~~~~~~
                                                                                %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:258:83: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess createIndex request ID %llu, object store id %lli", requestID, objectStoreID);
                                                     ~~~~                         ^~~~~~~~~
                                                     %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:258:94: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess createIndex request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                           ~~~~              ^~~~~~~~~~~~~
                                                                           %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:269:83: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteIndex request ID %llu, object store id %lli", requestID, objectStoreID);
                                                     ~~~~                         ^~~~~~~~~
                                                     %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:269:94: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteIndex request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                           ~~~~              ^~~~~~~~~~~~~
                                                                           %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:280:81: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess putRecord request ID %llu, object store id %lli", requestID, objectStoreID);
                                                   ~~~~                         ^~~~~~~~~
                                                   %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:280:92: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess putRecord request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                         ~~~~              ^~~~~~~~~~~~~
                                                                         %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:291:81: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess getRecord request ID %llu, object store id %lli", requestID, objectStoreID);
                                                   ~~~~                         ^~~~~~~~~
                                                   %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:291:92: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess getRecord request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                         ~~~~              ^~~~~~~~~~~~~
                                                                         %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:302:77: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess count request ID %llu, object store id %lli", requestID, objectStoreID);
                                               ~~~~                         ^~~~~~~~~
                                               %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:302:88: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess count request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                     ~~~~              ^~~~~~~~~~~~~
                                                                     %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:314:83: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteRange request ID %llu, object store id %lli", requestID, objectStoreID);
                                                     ~~~~                         ^~~~~~~~~
                                                     %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:314:94: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess deleteRange request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                           ~~~~              ^~~~~~~~~~~~~
                                                                           %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:326:82: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess openCursor request ID %llu, object store id %lli", requestID, objectStoreID);
                                                    ~~~~                         ^~~~~~~~~
                                                    %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:326:93: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess openCursor request ID %llu, object store id %lli", requestID, objectStoreID);
                                                                          ~~~~              ^~~~~~~~~~~~~
                                                                          %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:338:79: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess cursorAdvance request ID %llu, cursor id %lli", requestID, cursorID);
                                                       ~~~~                   ^~~~~~~~~
                                                       %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:338:90: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess cursorAdvance request ID %llu, cursor id %lli", requestID, cursorID);
                                                                       ~~~~              ^~~~~~~~
                                                                       %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:350:79: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
    LOG(IDB, "DatabaseProcess cursorIterate request ID %llu, cursor id %lli", requestID, cursorID);
                                                       ~~~~                   ^~~~~~~~~
                                                       %lu
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:350:90: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    LOG(IDB, "DatabaseProcess cursorIterate request ID %llu, cursor id %lli", requestID, cursorID);
                                                                       ~~~~              ^~~~~~~~
                                                                       %li
../../Source/WTF/wtf/Assertions.h:348:94: note: expanded from macro 'LOG'
#define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__)
                                                                                             ^
33 warnings generated.
[2526/2953] Building CXX object Source...queIDBDatabaseBackingStoreSQLite.cpp.o
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:617:101: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete object store id %lli from ObjectStoreInfo table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                        ~~~~                                        ^~~~~~~~~~~~~
                                                        %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:639:83: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete records for object store %lli (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                 ~~~~             ^~~~~~~~~~~~~
                                                                 %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:690:87: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete records from object store id %lli (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                     ~~~~             ^~~~~~~~~~~~~
                                                                     %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:700:93: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete records from index record store id %lli (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                           ~~~~             ^~~~~~~~~~~~~
                                                                           %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:812:88: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete index id %lli from IndexInfo table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                 ~~~~                                  ^~~~~~~~~~~~~
                                                 %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:823:109: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete index records for index id %lli from IndexRecords table (%i) - %s", indexID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                   ~~~~                                     ^~~~~~~
                                                                   %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:855:88: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete index id %lli from IndexInfo table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                 ~~~~                                  ^~~~~~~~~~~~~
                                                 %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:928:95: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
        LOG_ERROR("Could not get record from object store %lli from Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                          ~~~~                                ^~~~~~~~~~~~~
                                                          %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:976:96: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not put record for object store %lli in Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                             ~~~~                              ^~~~~~~~~~~~~
                                                             %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1024:116: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not put index record for index %lli in object store %lli in Records table (%i) - %s", indexID, objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                            ~~~~                                                   ^~~~~~~
                                                            %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1024:125: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not put index record for index %lli in object store %lli in Records table (%i) - %s", indexID, objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                                 ~~~~                                       ^~~~~~~~~~~~~
                                                                                 %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1168:83: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete record from object store %lli (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                 ~~~~             ^~~~~~~~~~~~~
                                                                 %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1181:95: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not delete record from indexes for object store %lli (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                             ~~~~             ^~~~~~~~~~~~~
                                                                             %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1212:99: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not get record from object store %lli from Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                              ~~~~                                ^~~~~~~~~~~~~
                                                              %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1223:99: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not get record from object store %lli from Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                              ~~~~                                ^~~~~~~~~~~~~
                                                              %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1265:109: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not get key range record from object store %lli from Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                                        ~~~~                                ^~~~~~~~~~~~~
                                                                        %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1277:99: warning: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Wformat]
            LOG_ERROR("Could not get record from object store %lli from Records table (%i) - %s", objectStoreID, m_sqliteDB->lastError(), m_sqliteDB->lastErrorMsg());
                                                              ~~~~                                ^~~~~~~~~~~~~
                                                              %li
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
../../Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:1361:66: warning: format specifies type 'long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
        LOG_ERROR("Attempt to advance cursor %lli steps failed", count);
                                             ~~~~                ^~~~~
                                             %lu
../../Source/WTF/wtf/Assertions.h:340:80: note: expanded from macro 'LOG_ERROR'
#define LOG_ERROR(...) WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, __VA_ARGS__)
                                                                               ^
18 warnings generated.

[Michael Catanzaro]

I guess these are just now showing up because we only recently enabled DatabaseProcess for GTK. Anyway, the three options are (a) use the proper PRIu64 and PRIi64 macros to print uint64_t and int64_t, (b) not use those types, or (c) not print things. (a) is best provided they exist on Mac; let's find out.

[Michael Catanzaro]

Created attachment 254859 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254859 [details]
Patch

Clearing flags on attachment: 254859

Committed r185546: <http://trac.webkit.org/changeset/185546>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.