Bug 145957 – [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

UIClient::close is currently exposed only view WKUIDelegatePrivate. Expose it via the public WKUIDelegate.

Created attachment 254856 [details]
Add -[id <WKUIDelegate> webViewDidClose:]

[Alexey Proskuryakov]

Comment on attachment 254856 [details]
Add -[id <WKUIDelegate> webViewDidClose:]

View in context: https://bugs.webkit.org/attachment.cgi?id=254856&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:65
> +- (void)webViewDidClose:(WKWebView *)webView;

I was told that we always - always! - add availability macros to new APIs.

(In reply to comment #2)
> Comment on attachment 254856 [details]
> Add -[id <WKUIDelegate> webViewDidClose:]
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254856&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h:65
> > +- (void)webViewDidClose:(WKWebView *)webView;
> 
> I was told that we always - always! - add availability macros to new APIs.

You were lied to. There have been a couple of exceptions, but we normally don’t add availability macros in protocols.

[Alexey Proskuryakov]

There isn't so much difference between this case and adding another error value to an enum. It would be nice to make decisions on some principle other than who bluffs more convincingly.

While not part of this patch, we are going to formalize the rules and apply them to all API.

[WebKit Commit Bot]

Comment on attachment 254856 [details]
Add -[id <WKUIDelegate> webViewDidClose:]

Clearing flags on attachment: 254856

Committed r185653: <http://trac.webkit.org/changeset/185653>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #5)
> While not part of this patch, we are going to formalize the rules and apply
> them to all API.

Added availability for this delegate method in r185794.

[Anders Carlsson]

*** Bug 146638 has been marked as a duplicate of this bug. ***