Bug 145949 – AX:ARIA Toggle buttons aren't properly conveyed on iOS using VoiceOver

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Accessibility

[chris fleizach]

We need to expose some attributes to the platform API to decide if an element has a pressed state.

[chris fleizach]

<rdar://problem/19073512>

[chris fleizach]

Created attachment 254835 [details]
patch

[Build Bot]

Comment on attachment 254835 [details]
patch

Attachment 254835 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6203648069599232

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode.html

[Build Bot]

Created attachment 254838 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 254835 [details]
patch

Attachment 254835 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5791548105031680

New failing tests:
inspector-protocol/dom/getAccessibilityPropertiesForNode.html

[Build Bot]

Created attachment 254839 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[chris fleizach]

*** Bug 129830 has been marked as a duplicate of this bug. ***

[chris fleizach]

Created attachment 254842 [details]
patch

[Darin Adler]

Comment on attachment 254842 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254842&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2221
> +    if (equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false"))
> +        return true;
> +    return false;

Should just be:

    return equalIgnoringCase(expanded, "true") || equalIgnoringCase(expanded, "false");

[James Craig]

Chris, rdar://19073512 was resolved in 2015. Anything left to do here?

[chris fleizach]

(In reply to James Craig from comment #10)
> Chris, rdar://19073512 was resolved in 2015. Anything left to do here?

ha, what happened with this bug. yea it looks like there's code that solves this, but not from this patch directly.