Bug 145946 - Add private API to force page to always run at foreground priority
Summary: Add private API to force page to always run at foreground priority
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-12 15:54 PDT by Gavin Barraclough
Modified: 2015-06-13 17:25 PDT (History)
2 users (show)

See Also:


Attachments
Fix (6.54 KB, patch)
2015-06-12 15:57 PDT, Gavin Barraclough
andersca: review+
Details | Formatted Diff | Diff
Patch for EWS (6.62 KB, patch)
2015-06-12 19:05 PDT, Gavin Barraclough
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2015-06-12 15:54:02 PDT
Useful for offscreen loading.
Comment 1 Gavin Barraclough 2015-06-12 15:57:54 PDT
Created attachment 254831 [details]
Fix
Comment 2 Anders Carlsson 2015-06-12 17:14:14 PDT
Comment on attachment 254831 [details]
Fix

Isn't this iOS only? If so, it should be inside the PLATFORM(IOS) section below (and the TARGET_IOS_IPHONE section in the header).
Comment 3 Anders Carlsson 2015-06-12 17:14:30 PDT
Also, WK_MAC_TBA should be NA.
Comment 4 Gavin Barraclough 2015-06-12 19:05:51 PDT
Created attachment 254847 [details]
Patch for EWS
Comment 5 WebKit Commit Bot 2015-06-13 11:46:41 PDT
Comment on attachment 254847 [details]
Patch for EWS

Rejecting attachment 254847 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 254847, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Anders Carlson found in /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5723490053259264
Comment 6 Gavin Barraclough 2015-06-13 17:25:31 PDT
Transmitting file data ......
Committed revision 185541.