Bug 145936 – [Mac] AirPlay menu button doesn't always show on page load

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

The AirPlay menu button isn't always visible when the first page with <video> loads.

[Eric Carlson]

<rdar://problem/21330128>

[Eric Carlson]

Created attachment 254816 [details]
Proposed patch.

[WebKit Commit Bot]

Attachment 254816 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:78:  The parameter name "tasks" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 254816 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=254816&action=review

r=me. I noticed a couple of typos, but nothing that needs to be re-reviewed.

> Source/WebCore/ChangeLog:9
> +        (WebCore::mediaProducerStateString): New, return a stream representing MediaStateFlags.

return a *string* (not stream)?

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebMediaSessionManager::toString): New, return a stream representing ConfigurationTasks.

return a *string* (not stream)?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:178
> +    virtual bool wirelessVideoPlaybackDisabled() const override { return false; }

We don't need to write 'virtual' when we also write 'override'. We've been changing this style elsewhere. But I don't care if you do so in this patch.

[Eric Carlson]

Committed r185519: https://trac.webkit.org/r185519