Bug 145922 – [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

DerivedSources/webkit2gtk/webkit2/WebKitMarshal.cpp:65:3: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register]
  register GMarshalFunc_BOOLEAN__BOXED callback;
  ^~~~~~~~~
DerivedSources/webkit2gtk/webkit2/WebKitMarshal.cpp:66:3: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register]
  register GCClosure *cc = (GCClosure*) closure;
  ^~~~~~~~~

...

The problem is that WebKitMarshal.cpp is generated by glib-genmarshal. To fix 
it properly, we should fix it in upstream or patch the glib jhbuild module.
Or we should simply disable this warning for this file only.

[Michael Catanzaro]

(In reply to comment #0)
> To fix it properly, we should fix it in upstream

Done. I usually build inside GNOME jhbuild, so the problem is gone for me :)

> or patch the glib jhbuild module. Or we should simply disable this warning for this file only.

^ But to fix the issue with WebKit jhbuild, we still need to do one of the above.

[Csaba Osztrogonác]

Created attachment 254872 [details]
Patch

Thanks for the quick fix. I prefer adding your upstream patch to the WebKit's jhbuild

[WebKit Commit Bot]

Comment on attachment 254872 [details]
Patch

Clearing flags on attachment: 254872

Committed r185550: <http://trac.webkit.org/changeset/185550>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.