Bug 145921 - Fix missing braces and deprecated declarations warnings in WebKitNotificationProvider.cpp
Summary: Fix missing braces and deprecated declarations warnings in WebKitNotification...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency treegraph
 
Reported: 2015-06-12 04:22 PDT by Csaba Osztrogonác
Modified: 2015-06-18 07:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2015-06-18 06:20 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-12 04:22:33 PDT
../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: suggest braces around initialization of subobject [-Wmissing-braces]
        kWKNotificationProviderCurrentVersion,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WebKit2/UIProcess/API/gtk/WebKitNotificationProvider.cpp:75:9: warning: 'kWKNotificationProviderCurrentVersion' is deprecated: Use an explicit version number instead [-Wdeprecated-declarations]
../../Source/WebKit2/UIProcess/API/C/WKNotificationProvider.h:61:8: note: 'kWKNotificationProviderCurrentVersion' has been explicitly marked deprecated here
enum { kWKNotificationProviderCurrentVersion __attribute__((deprecated("Use an explicit version number instead"))) = 0, };
       ^
2 warnings generated.
Comment 1 Csaba Osztrogonác 2015-06-18 06:20:00 PDT
Created attachment 255111 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-18 06:22:53 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2015-06-18 07:14:40 PDT
Comment on attachment 255111 [details]
Patch

Clearing flags on attachment: 255111

Committed r185700: <http://trac.webkit.org/changeset/185700>
Comment 4 WebKit Commit Bot 2015-06-18 07:14:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Michael Catanzaro 2015-06-18 07:31:42 PDT
Got to say, I'm amazed that code was legal....