Bug 145920 - Fix overloaded virtual function warning in ScrollbarThemeGtk.h
Summary: Fix overloaded virtual function warning in ScrollbarThemeGtk.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2015-06-12 04:16 PDT by Csaba Osztrogonác
Modified: 2015-07-10 10:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2015-07-10 07:43 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-12 04:16:15 PDT 
In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27:
../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:48:13: warning: 'WebCore::ScrollbarThemeGtk::thumbRect' hides overloaded virtual function [-Woverloaded-virtual]
    IntRect thumbRect(ScrollbarThemeClient*, const IntRect& unconstrainedTrackRect);
            ^
../../Source/WebCore/platform/ScrollbarThemeComposite.h:58:21: note: hidden overloaded virtual function 'WebCore::ScrollbarThemeComposite::thumbRect' declared here: different number of parameters (1 vs 2)
    virtual IntRect thumbRect(ScrollbarThemeClient*);
                    ^
1 warning generated.
Comment 1 Csaba Osztrogonác 2015-07-10 07:43:52 PDT 
Created attachment 256580 [details]
Patch

Now the thumbRect of the baseclass isn't used (it would be compile error), but the easiest way to fix this warning is to unhide it for the compiler with an explicit using.
Comment 2 WebKit Commit Bot 2015-07-10 10:39:24 PDT 
Comment on attachment 256580 [details]
Patch

Clearing flags on attachment: 256580

Committed r186680: <http://trac.webkit.org/changeset/186680>
Comment 3 WebKit Commit Bot 2015-07-10 10:39:28 PDT 
All reviewed patches have been landed.  Closing bug.