RESOLVED FIXED 145907
Add the remaining missing override specifiers under Source/WebCore/ 
https://bugs.webkit.org/show_bug.cgi?id=145907
Summary Add the remaining missing override specifiers under Source/WebCore/
Zan Dobersek
Reported 2015-06-11 23:22:11 PDT
Add the remaining missing override specifiers under Source/WebCore/
Attachments
Patch (41.98 KB, patch)
2015-06-11 23:36 PDT, Zan Dobersek 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2015-06-11 23:36:07 PDT
Created attachment 254779 [details] Patch
Darin Adler
Comment 2 2015-06-12 09:45:54 PDT
Comment on attachment 254779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254779&action=review > Source/WebCore/ChangeLog:13 > + Where the addition had to be performed on all virtual methods of the > + class, the virtual specifier was removed so now only the override > + specifier is in use. Still a bit controversial, but Antti did suggest this and nobody said no! > Source/WebCore/ChangeLog:22 > + (WebCore::EqualPowerPanner::reset): Deleted. I understand that the prepare change log script generated all of these, but please remove them. I don’t think it does anyone any good to list all these functions as deleted in the change log.
Zan Dobersek
Comment 3 2015-06-12 11:31:01 PDT
Comment on attachment 254779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254779&action=review >> Source/WebCore/ChangeLog:22 >> + (WebCore::EqualPowerPanner::reset): Deleted. > > I understand that the prepare change log script generated all of these, but please remove them. I don’t think it does anyone any good to list all these functions as deleted in the change log. Will do.
Zan Dobersek
Comment 4 2015-06-12 11:49:29 PDT
Committed r185518: <http://trac.webkit.org/changeset/185518>
Note You need to log in before you can comment on or make changes to this bug.