Bug 145895 - Full screen video space can be resized to 1pt wide
Summary: Full screen video space can be resized to 1pt wide
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-11 13:23 PDT by Brent Fulgham
Modified: 2015-08-27 18:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2015-06-11 13:28 PDT, Brent Fulgham
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-06-11 13:23:12 PDT
In tiled mode, you can resize the full-screen video WebView to 1pt wide. This should not be possible.
Comment 1 Brent Fulgham 2015-06-11 13:23:34 PDT
<rdar://problem/20907914>
Comment 2 Brent Fulgham 2015-06-11 13:28:24 PDT
Created attachment 254753 [details]
Patch
Comment 3 Brent Fulgham 2015-06-11 13:29:48 PDT
Related: <rdar://problem/21150721>
Comment 4 Brent Fulgham 2015-06-11 14:06:54 PDT
Committed r185473: <http://trac.webkit.org/changeset/185473>
Comment 5 Tim Horton 2015-08-16 17:59:58 PDT
Whaaa. This should not be using kWKLayoutModeDynamicSizeWithMinimumViewSize (nothing should! I just got here because I was about to delete it). Probably wanted the default, kWKLayoutModeViewSize. But also, you always reset to kWKLayoutModeViewSize, ignoring whatever it was before! I bet there's a lot of brokenness going into/out of fullscreen with a page that is scaled-down in Split View.
Comment 6 Tim Horton 2015-08-16 18:01:10 PDT
It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that.
Comment 7 Tim Horton 2015-08-16 18:01:10 PDT
It's nontrivial to internally swap to a different layout mode and still come back to the right thing (respecting changes that come in from API clients, etc.), but I just implemented this for PDF, so we can probably reuse that.
Comment 8 Tim Horton 2015-08-27 18:39:06 PDT
Patch to move to the better thing: https://bugs.webkit.org/show_bug.cgi?id=148553