Bug 145878 – [EFL] canvas/philip/tests/toDataURL.jpeg.foo tests have been failed since r185417.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Hunseop Jeong]

canvas/philip/tests/toDataURL.jpeg.primarycolours.html [ Failure ]
canvas/philip/tests/toDataURL.jpeg.quality.basic.html [ Failure ]

[KwangHyuk]

(In reply to comment #0)
> canvas/philip/tests/toDataURL.jpeg.primarycolours.html [ Failure ]
> canvas/philip/tests/toDataURL.jpeg.quality.basic.html [ Failure ]

Oops R-B converting should be there on original source code of JPEG encoder.
Could you fix it ?
May be, you should use EFL macro.

[Hunseop Jeong]

Created attachment 254718 [details]
WIP

I uploaded the patch to fix the "toDataURL.jpeg.primarycolours" test.
But it doesn't look good to me.

[KwangHyuk]

(In reply to comment #2)
> Created attachment 254718 [details]
> WIP
> 
> I uploaded the patch to fix the "toDataURL.jpeg.primarycolours" test.
> But it doesn't look good to me.

Input data seem to be pre-processed in order to let JPEGImageEncoder handle it correctly.

[KwangHyuk]

Created attachment 254726 [details]
Patch

[KwangHyuk]

toDataURL.​jpeg.​primarycolours : passed
toDataURL.​jpeg.​quality.​basic : still has more issue related with image quality.

still working in progress.

[KwangHyuk]

Created attachment 254727 [details]
Patch

[KwangHyuk]

for this test toDataURL.​jpeg.​quality.​basic, Chrome and firefox shows same result. (refer the attached screenshot)
Therefore test should be ignored.

[KwangHyuk]

Created attachment 254728 [details]
screenshot - chrome browser

[KwangHyuk]

Created attachment 254729 [details]
screenshot - firefox

[Gyuyoung Kim]

Comment on attachment 254727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254727&action=review

> Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:72
> +        int w = cairo_image_surface_get_width(image);

s/w/width/g

> Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:73
> +        int h = cairo_image_surface_get_height(image);

s/h/height/g

> Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:87
> +{    

Added unnecessary spaces.

[KwangHyuk]

Created attachment 254802 [details]
Patch

[KwangHyuk]

(In reply to comment #10)
> Comment on attachment 254727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254727&action=review
> 
> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:72
> > +        int w = cairo_image_surface_get_width(image);
> 
> s/w/width/g
> 
Thank you, fixed.

> > Source/WebCore/platform/graphics/efl/ImageBufferEfl.cpp:73
> > +        int h = cairo_image_surface_get_height(image);
> 
> s/h/height/g
> 
> > Source/WebCore/platform/image-encoders/JPEGImageEncoder.cpp:87
> > +{    
> 
> Added unnecessary spaces.

Fixed too. :)

[KwangHyuk]

Created attachment 254804 [details]
RB conversion

[KwangHyuk]

Created attachment 254805 [details]
RB conversion

[WebKit Commit Bot]

Comment on attachment 254805 [details]
RB conversion

Clearing flags on attachment: 254805

Committed r185506: <http://trac.webkit.org/changeset/185506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.