Bug 145855 - Overriding the overlay scrollbar style on WKView doesn't take effect immediately
Summary: Overriding the overlay scrollbar style on WKView doesn't take effect immediately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-10 14:22 PDT by Beth Dakin
Modified: 2015-06-10 14:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2015-06-10 14:42 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-06-10 14:22:26 PDT 
If the scrollbar style is changed dynamically after the WKView is loaded, then the new style won't actually change until rubber-banding.

rdar://problem/20948706
Comment 1 Beth Dakin 2015-06-10 14:42:59 PDT 
Created attachment 254677 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-06-10 14:44:19 PDT 
Comment on attachment 254677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254677&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020
> +    if (!painter)
> +        return;
> +    [painter setNeedsDisplay:YES];

It would be OK removing the null check, since messaging nil is OK.
Comment 3 Beth Dakin 2015-06-10 14:54:57 PDT 
(In reply to comment #2)
> Comment on attachment 254677 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254677&action=review
> 
> > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020
> > +    if (!painter)
> > +        return;
> > +    [painter setNeedsDisplay:YES];
> 
> It would be OK removing the null check, since messaging nil is OK.

Good point. Removed!

Thanks, Simon! http://trac.webkit.org/changeset/185431