RESOLVED FIXED 145854
Move all content extension tests to same directory to fix flakiness 
https://bugs.webkit.org/show_bug.cgi?id=145854
Summary Move all content extension tests to same directory to fix flakiness
Alex Christensen
Reported 2015-06-10 14:09:39 PDT
Right now there are two directories with content extension tests, which causes them to be run with two WebKitTestRunners at the same time, and sometimes they delete each other's content extension when resetting the state between tests. I'm pretty sure this is what is causing flakiness like http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions&revision=185388
Attachments
Patch (6.12 KB, patch)
2015-06-10 14:12 PDT, Alex Christensen 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-06-10 14:12:16 PDT
Created attachment 254675 [details] Patch
Alexey Proskuryakov
Comment 2 2015-06-10 14:17:11 PDT
Comment on attachment 254675 [details] Patch This is ok as a short term fix, however the requirement to have all these tests in one directory is not something that we should remember forever, and also we should have tests work with -f. How can we make parallel testing processes independent?
Alex Christensen
Comment 3 2015-06-10 14:36:57 PDT
http://trac.webkit.org/changeset/185430 The problem is related to the call to _removeAllContentExtensions in TestControllerMac.mm but I'm not sure how to safely make it work with different directories. And I'm only about 90% sure this moving-all-tests-to-the-same-directory will work.
Note You need to log in before you can comment on or make changes to this bug.