Bug 145850 – Simplify things like CompareEq(@x,@x)

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

I'm seeing cases where these sort of float past our optimizations.  It's all because of silly omissions, like AI not handling CompareEq(@x, @x) and CFG simplification not being run in SSA.

[Filip Pizlo]

Created attachment 254680 [details]
should just work

[Filip Pizlo]

Created attachment 257330 [details]
the patch

[WebKit Commit Bot]

Attachment 257330 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1193:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1193:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1194:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1195:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1196:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1197:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1198:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1199:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1253:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1253:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1254:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1255:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1256:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1257:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1258:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1259:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1260:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1261:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1262:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1263:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 20 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

(In reply to comment #3)
> Attachment 257330 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1193: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1193: 
> Multi line control clauses should use braces.  [whitespace/braces] [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1194: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1195: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1196: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1197: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1198: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1199: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1253: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1253: 
> Multi line control clauses should use braces.  [whitespace/braces] [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1254: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1255: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1256: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1257: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1258: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1259: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1260: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1261: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1262: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1263: 
> Boolean expressions that span multiple lines should have their operators on
> the left side of the line instead of the right side.  [whitespace/operators]
> [4]
> Total errors found: 20 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I intentionally broke with the custom here because I wanted the various conditions to line up.  I think it makes the code more legible in this case.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/187213