Bug 145849 - MediaRemoteControls should be marked JSGenerateToJSObject
Summary: MediaRemoteControls should be marked JSGenerateToJSObject
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency treegraph
Reported: 2015-06-10 11:51 PDT by Matt Rajca
Modified: 2015-06-10 13:51 PDT (History)
6 users (show)

See Also:

Patch (1.52 KB, patch)
2015-06-10 11:56 PDT, Matt Rajca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-10 11:51:24 PDT
Since MediaRemoteControls has a parent interface, we need to add the JSGenerateToJSObject attribute so the toJS(...) function gets generated. This is required to get event handling to work.
Comment 1 Radar WebKit Bug Importer 2015-06-10 11:52:33 PDT
Comment 2 Matt Rajca 2015-06-10 11:56:05 PDT
Created attachment 254667 [details]
Comment 3 WebKit Commit Bot 2015-06-10 13:51:22 PDT
Comment on attachment 254667 [details]

Clearing flags on attachment: 254667

Committed r185429: <http://trac.webkit.org/changeset/185429>
Comment 4 WebKit Commit Bot 2015-06-10 13:51:27 PDT
All reviewed patches have been landed.  Closing bug.