WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145847
Add barebones implementation of media session invocation algorithm
https://bugs.webkit.org/show_bug.cgi?id=145847
Summary
Add barebones implementation of media session invocation algorithm
Matt Rajca
Reported
2015-06-10 11:32:32 PDT
Add a barebones implementation of the media session invocation algorithm that at least moves the media session to an ACTIVE state so MediaPlayPause events can function.
Attachments
Patch
(3.63 KB, patch)
2015-06-10 11:38 PDT
,
Matt Rajca
no flags
Details
Formatted Diff
Diff
Patch
(3.63 KB, patch)
2015-06-11 15:33 PDT
,
Matt Rajca
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-06-10 11:33:24 PDT
<
rdar://problem/21324294
>
Matt Rajca
Comment 2
2015-06-10 11:38:59 PDT
Created
attachment 254665
[details]
Patch
Matt Rajca
Comment 3
2015-06-11 15:33:46 PDT
Created
attachment 254762
[details]
Patch
Darin Adler
Comment 4
2015-06-12 09:53:55 PDT
Comment on
attachment 254762
[details]
Patch This is fine, but I am concerned about us adding this code without tests. When will we be adding the tests?
Matt Rajca
Comment 5
2015-06-12 09:59:56 PDT
(In reply to
comment #4
)
> Comment on
attachment 254762
[details]
> Patch > > This is fine, but I am concerned about us adding this code without tests. > When will we be adding the tests?
Once I add basic support for the other two media event types (next track and previous track), I will work on tests.
WebKit Commit Bot
Comment 6
2015-06-12 10:54:11 PDT
Comment on
attachment 254762
[details]
Patch Clearing flags on attachment: 254762 Committed
r185514
: <
http://trac.webkit.org/changeset/185514
>
WebKit Commit Bot
Comment 7
2015-06-12 10:54:16 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug