Bug 145847 - Add barebones implementation of media session invocation algorithm
Summary: Add barebones implementation of media session invocation algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-06-10 11:32 PDT by Matt Rajca
Modified: 2015-06-12 10:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2015-06-10 11:38 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Patch (3.63 KB, patch)
2015-06-11 15:33 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-10 11:32:32 PDT 
Add a barebones implementation of the media session invocation algorithm that at least moves the media session to an ACTIVE state so MediaPlayPause events can function.
Comment 1 Radar WebKit Bug Importer 2015-06-10 11:33:24 PDT 
<rdar://problem/21324294>
Comment 2 Matt Rajca 2015-06-10 11:38:59 PDT 
Created attachment 254665 [details]
Patch
Comment 3 Matt Rajca 2015-06-11 15:33:46 PDT 
Created attachment 254762 [details]
Patch
Comment 4 Darin Adler 2015-06-12 09:53:55 PDT 
Comment on attachment 254762 [details]
Patch

This is fine, but I am concerned about us adding this code without tests. When will we be adding the tests?
Comment 5 Matt Rajca 2015-06-12 09:59:56 PDT 
(In reply to comment #4)
> Comment on attachment 254762 [details]
> Patch
> 
> This is fine, but I am concerned about us adding this code without tests.
> When will we be adding the tests?

Once I add basic support for the other two media event types (next track and previous track), I will work on tests.
Comment 6 WebKit Commit Bot 2015-06-12 10:54:11 PDT 
Comment on attachment 254762 [details]
Patch

Clearing flags on attachment: 254762

Committed r185514: <http://trac.webkit.org/changeset/185514>
Comment 7 WebKit Commit Bot 2015-06-12 10:54:16 PDT 
All reviewed patches have been landed.  Closing bug.