Bug 145838 - [EFL] Implement minibrowser:version Web UI using custom scheme.
Summary: [EFL] Implement minibrowser:version Web UI using custom scheme.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hyungwook Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-10 04:50 PDT by Hyungwook Lee
Modified: 2015-09-14 10:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2015-06-10 07:28 PDT, Hyungwook Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyungwook Lee 2015-06-10 04:50:42 PDT
Implement about:version Web UI using custom scheme.
Comment 1 Hyungwook Lee 2015-06-10 07:28:52 PDT
Created attachment 254649 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-14 21:08:31 PDT
Comment on attachment 254649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review

> Tools/MiniBrowser/efl/main.c:1041
> +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))

Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser.
Comment 3 Ryuan Choi 2015-06-14 21:35:11 PDT
(In reply to comment #2)
> Comment on attachment 254649 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254649&action=review
> 
> > Tools/MiniBrowser/efl/main.c:1041
> > +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))
> 
> Hmm... to be honest, MiniBrowser is a just simple application. In GTK
> MiniBrowser case, they didn't add new feature because minibrowser is just
> test application for own WebKit port. I don't know we need to add this
> feature to EFL MiniBrowser.

I also don't think that it is usefull for MiniBrowser to have this.

MiniBrowser is just simple browser to test basic functionality.
Comment 4 Hyungwook Lee 2015-06-14 23:25:26 PDT
Comment on attachment 254649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review

>>> Tools/MiniBrowser/efl/main.c:1041
>>> +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))
>> 
>> Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser.
> 
> I also don't think that it is usefull for MiniBrowser to have this.
> 
> MiniBrowser is just simple browser to test basic functionality.

I referenced GTK Mini Browser that supports 'about:minibrowser' scheme to show current version using Web UI.

I think Web UI is very useful function for Mini Browser to provide many functions easily.
ex) Settings, History, Cache Status, WebKit Debugging UI, etc...

Actually I want to implement WebKit Debugging UI and WebKit Setting UI using Web UI for developer who want to enable / disable some features in runtime.
Comment 5 Csaba Osztrogonác 2015-09-14 10:55:32 PDT
Comment on attachment 254649 [details]
Patch

Cleared review? from attachment 254649 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).