Bug 145824 - MediaControls: Reenable resize of controls on pinch zoom
Summary: MediaControls: Reenable resize of controls on pinch zoom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-09 16:29 PDT by Dean Jackson
Modified: 2015-06-09 17:54 PDT (History)
0 users

See Also:

Attachments
Patch (4.79 KB, patch)
2015-06-09 16:33 PDT, Dean Jackson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-06-09 16:29:54 PDT 
MediaControls: Reenable resize of controls on pinch zoom
Comment 1 Dean Jackson 2015-06-09 16:30:12 PDT 
<rdar://problem/21212778>
Comment 2 Dean Jackson 2015-06-09 16:33:14 PDT 
Created attachment 254614 [details]
Patch
Comment 3 Darin Adler 2015-06-09 16:40:47 PDT 
Comment on attachment 254614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631
> +        if (newScaleFactor) {

Early return maybe to not nest this entire thing.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640
> +                this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%";

Why ceil rather than round?
Comment 4 Dean Jackson 2015-06-09 17:53:25 PDT 
Comment on attachment 254614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254614&action=review

>> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:631
>> +        if (newScaleFactor) {
> 
> Early return maybe to not nest this entire thing.

Done.

>> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:640
>> +                this.controls.panel.style.width = Math.ceil(newScaleFactor * 100) + "%";
> 
> Why ceil rather than round?

We got a few complaints about the bar not quite covering the media do to rounding down. But I'm going to go back to round to see what happens.
Comment 5 Dean Jackson 2015-06-09 17:54:04 PDT 
Committed r185397: <http://trac.webkit.org/changeset/185397>
Comment 6 Dean Jackson 2015-06-09 17:54:19 PDT 
Committed r185397: <http://trac.webkit.org/changeset/185397>