Bug 145811 - JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Summary: JavaScript bindings are unnecessarily checking for impossible empty JSValue a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on: 145815
Blocks:
  Show dependency tree / graph
 
Reported: 2015-06-09 12:37 PDT by Darin Adler
Modified: 2015-06-09 14:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (90.57 KB, patch)
2015-06-09 12:47 PDT, Darin Adler 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-06-09 12:37:33 PDT 
JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Comment 1 Darin Adler 2015-06-09 12:47:38 PDT 
Created attachment 254592 [details]
Patch
Comment 2 Darin Adler 2015-06-09 12:48:28 PDT 
Brady, this is fixing the isEmpty issue I spotted in the patch you were working on.
Comment 3 Antti Koivisto 2015-06-09 12:54:48 PDT 
Comment on attachment 254592 [details]
Patch

Nice cleanup. r=me
Comment 4 Darin Adler 2015-06-09 12:55:33 PDT 
Committed r185373: <http://trac.webkit.org/changeset/185373>
Comment 5 WebKit Commit Bot 2015-06-09 14:17:13 PDT 
Re-opened since this is blocked by bug 145815
Comment 6 Darin Adler 2015-06-09 14:18:59 PDT 
Committed r185377: <http://trac.webkit.org/changeset/185377>