Bug 145790 - [GTK] Allow to dispatch tasks in WorkQueue with different priorities
Summary: [GTK] Allow to dispatch tasks in WorkQueue with different priorities
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-06-09 00:46 PDT by Carlos Garcia Campos
Modified: 2015-11-23 01:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2015-06-09 00:51 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-06-09 00:46:58 PDT 
In glib we can use different priorities for the sources in the same main loop. I want to use this to give more priority to read tasks in the disk cache IO WorkQueue, but it could be useful for other cases as well.
Comment 1 Carlos Garcia Campos 2015-06-09 00:51:32 PDT 
Created attachment 254554 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-09 00:52:34 PDT 
Attachment 254554 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/WorkQueue.h:77:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/WorkQueue.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:114:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:126:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:130:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/glib/WorkQueueGLib.cpp:133:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2015-06-09 05:22:14 PDT 
In the test case, why name the nonmember variables with the m_ prefix?
Comment 4 Carlos Garcia Campos 2015-06-09 05:28:29 PDT 
(In reply to comment #3)
> In the test case, why name the nonmember variables with the m_ prefix?

Good question, there's no reason other than I copy-pasted from Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp :-P
Comment 5 Carlos Garcia Campos 2015-06-09 10:13:47 PDT 
We are no longer using this for the disk cache, so I guess we don't really need it for now.
Comment 6 Zan Dobersek 2015-11-23 01:11:51 PST 
RESOLVED LATER?
Comment 7 Zan Dobersek 2015-11-23 01:18:52 PST 
RESOLVED LATER.