Bug 145779 - Missing content in UIWebView snapshots sometimes
Summary: Missing content in UIWebView snapshots sometimes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-08 17:31 PDT by Simon Fraser (smfr)
Modified: 2015-06-11 11:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2015-06-08 17:34 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-06-08 17:31:55 PDT 
Missing content in UIWebView snapshots sometimes
Comment 1 Simon Fraser (smfr) 2015-06-08 17:34:36 PDT 
Created attachment 254528 [details]
Patch
Comment 2 Darin Adler 2015-06-08 17:44:14 PDT 
Comment on attachment 254528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254528&action=review

> Source/WebCore/platform/ios/LegacyTileLayer.mm:35
> +using namespace WebCore;

If we are going to add this, then are we going to remove all the other WebCore prefixes in this file? Maybe we should just use WebCore::FloatRect in the one place it matters.

> Source/WebCore/platform/ios/LegacyTileLayer.mm:62
> +    _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>(dirtyRect));

I think just FloatRect(dirtyRect) would be better here.

> Source/WebCore/platform/ios/LegacyTileLayer.mm:67
> +    _tileGrid->tileCache().setOverrideVisibleRect(Optional<FloatRect>());

Nullopt is the normal way to write this.
Comment 3 Simon Fraser (smfr) 2015-06-11 10:29:15 PDT 
<rdar://problem/20744708>
Comment 4 Simon Fraser (smfr) 2015-06-11 11:03:02 PDT 
https://trac.webkit.org/r185461