Bug 145764 - run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
Summary: run-benchmark should either checkout JetStream 1.0.1 or support running the l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 145762
  Show dependency tree / graph
 
Reported: 2015-06-08 12:48 PDT by Ryosuke Niwa
Modified: 2015-06-09 12:30 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (6.83 KB, patch)
2015-06-08 14:31 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-06-08 12:48:57 PDT 
run-benchmark currently hard-codes 1.0.1 in its plan for JetStream and expects the ToT WebKit checkout to produce this version.

We need to either download 1.0.1 or support running the latest version.

It's probably preferable to download 1.0.1 since we want to able to control when change the benchmark we run.
Comment 1 Filip Pizlo 2015-06-08 12:50:44 PDT 
Let's change it to check out 1.0.1.  We should only have the perf dashboard rev-up to the latest version of the benchmark when we are ready.  We don't want the dashboard to have a meaningless jitter every time someone makes an incremental change to a benchmark.
Comment 2 Ryosuke Niwa 2015-06-08 13:40:35 PDT 
Okay, let me write a patch to do that.
Comment 3 Ryosuke Niwa 2015-06-08 14:31:56 PDT 
Created attachment 254509 [details]
Fixes the bug
Comment 4 Darin Adler 2015-06-09 11:40:44 PDT 
Comment on attachment 254509 [details]
Fixes the bug

rs=me
Comment 5 WebKit Commit Bot 2015-06-09 12:30:03 PDT 
Comment on attachment 254509 [details]
Fixes the bug

Clearing flags on attachment: 254509

Committed r185371: <http://trac.webkit.org/changeset/185371>
Comment 6 WebKit Commit Bot 2015-06-09 12:30:07 PDT 
All reviewed patches have been landed.  Closing bug.