WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145757
Fix unused private field warning in GraphicsLayerUpdater.h
https://bugs.webkit.org/show_bug.cgi?id=145757
Summary
Fix unused private field warning in GraphicsLayerUpdater.h
Csaba Osztrogonác
Reported
2015-06-08 06:39:05 PDT
clang build log: ----------------- In file included from ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:27: ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:66:33: warning: private field 'm_client' is not used [-Wunused-private-field] GraphicsLayerUpdaterClient& m_client; m_client is only used if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is true. But it is true only on Cocoa platform. Let's guard this member properly.
Attachments
Patch
(2.44 KB, patch)
2015-06-08 06:41 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2015-06-08 06:41:04 PDT
Created
attachment 254490
[details]
Patch
Darin Adler
Comment 2
2015-06-09 11:42:04 PDT
Comment on
attachment 254490
[details]
Patch Is there any way to do this more elegantly and thoroughly? I’m not sure what the value is of having a virtual destructor and a boolean when USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
WebKit Commit Bot
Comment 3
2015-06-09 12:30:45 PDT
Comment on
attachment 254490
[details]
Patch Clearing flags on attachment: 254490 Committed
r185372
: <
http://trac.webkit.org/changeset/185372
>
WebKit Commit Bot
Comment 4
2015-06-09 12:30:48 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug