Bug 145757 - Fix unused private field warning in GraphicsLayerUpdater.h
Summary: Fix unused private field warning in GraphicsLayerUpdater.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 145121
  Show dependency tree / graph
 
Reported: 2015-06-08 06:39 PDT by Csaba Osztrogonác
Modified: 2015-06-09 12:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2015-06-08 06:41 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-08 06:39:05 PDT 
clang build log:
-----------------
In file included from ../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:27:
../../Source/WebCore/platform/graphics/GraphicsLayerUpdater.h:66:33: warning: private field 'm_client' is not used [-Wunused-private-field]
    GraphicsLayerUpdaterClient& m_client;

m_client is only used if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) 
is true. But it is true only on Cocoa platform.

Let's guard this member properly.
Comment 1 Csaba Osztrogonác 2015-06-08 06:41:04 PDT 
Created attachment 254490 [details]
Patch
Comment 2 Darin Adler 2015-06-09 11:42:04 PDT 
Comment on attachment 254490 [details]
Patch

Is there any way to do this more elegantly and thoroughly? I’m not sure what the value is of having a virtual destructor and a boolean when USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is false.
Comment 3 WebKit Commit Bot 2015-06-09 12:30:45 PDT 
Comment on attachment 254490 [details]
Patch

Clearing flags on attachment: 254490

Committed r185372: <http://trac.webkit.org/changeset/185372>
Comment 4 WebKit Commit Bot 2015-06-09 12:30:48 PDT 
All reviewed patches have been landed.  Closing bug.